care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Minor Improvement of UI of medicine tab in patient dashboard page

Open patelaryan7751 opened this issue 2 years ago • 7 comments

Proposed Changes

Fixes #3384

  • The Prescription Time should come down the next line below the Prescription Heading
  • Horizontal padding should be added in the box containing the message "No Consultation Updates Found" in Consultation Updates section image

@coronasafe/reviewers

Merge Checklist

  • [ ] Add specs that demonstrate bug / test a new feature.
  • [ ] Update product documentation.
  • [ ] Ensure that UI text is kept in I18n files.
  • [ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [ ] Request for Peer Reviews
  • [ ] Completion of QA

patelaryan7751 avatar Aug 15 '22 10:08 patelaryan7751

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit fd885814a1df843783c238fd796791915b68db65
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63169b80f6e2150008e221e3
Deploy Preview https://deploy-preview-3408--care-egov-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 15 '22 10:08 netlify[bot]

@patelaryan7751 once the work is completed, change it to need testing

nihal467 avatar Aug 16 '22 13:08 nihal467

@patelaryan7751 image

moving the time from left to right in the normal view was intentional or not ! as currently staging it is on the left near the prescription heading !

nihal467 avatar Aug 24 '22 16:08 nihal467

@nihal467 It was not intentional i have fixed the bug image

Now the page would look like this in samsung fold

image

patelaryan7751 avatar Aug 30 '22 21:08 patelaryan7751

test approved

nihal467 avatar Aug 31 '22 06:08 nihal467

@developedBySJ can you rereview this one?

khavinshankar avatar Sep 01 '22 08:09 khavinshankar

@patelaryan7751 merge the latest development branch and check the cypress test is passing or not,

nihal467 avatar Sep 05 '22 20:09 nihal467

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 06 '22 01:09 sonarqubecloud[bot]