care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Add procedure in consultation update

Open arpancodes opened this issue 2 years ago • 7 comments

fixes #3195 Added procedure components for consultation update.

image
image

arpancodes avatar Aug 08 '22 15:08 arpancodes

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit ca3d10de4c49b8b9655a5d37cb5733ca16f86e3a
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/635e12bdfb45ac00099e93bc
Deploy Preview https://deploy-preview-3356--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 08 '22 15:08 netlify[bot]

test approved

nihal467 avatar Aug 09 '22 21:08 nihal467

@arpancodes Using different code-formatting makes it almost impossible to review. Can you fix this?

The formatted files were actually unrelated to the PR, I guess they are old ones that's why prettier just changed every bit of those files. Removed from the PR.

arpancodes avatar Aug 11 '22 15:08 arpancodes

@arpancodes Can we close this ASAP?

aparnacoronasafe avatar Aug 19 '22 14:08 aparnacoronasafe

@khavinshankar is everything fine?

arpancodes avatar Aug 19 '22 19:08 arpancodes

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 19 '22 19:08 sonarqubecloud[bot]

@arpancodes I see changes requested. Please look into this and try closing it this week

aparnacoronasafe avatar Aug 23 '22 04:08 aparnacoronasafe

@aparnacoronasafe check the merge conflict, and merge latest development branch and check cypress is passing or not

nihal467 avatar Sep 05 '22 20:09 nihal467

:wave: Hi, @arpancodes, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

mathew-alex avatar Sep 27 '22 10:09 mathew-alex

Hi, @${author}, This pr/issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

stale[bot] avatar Oct 08 '22 12:10 stale[bot]

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex This pr/issue has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr/issue.

stale[bot] avatar Oct 15 '22 16:10 stale[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Oct 30, 2022 at 6:00AM (UTC)

vercel[bot] avatar Oct 30 '22 02:10 vercel[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 30 '22 06:10 sonarqubecloud[bot]

@khavinshankar image

  • [ ] currently, when you hover over yes/no, and select yes/no , until you don't hover out of yes/no, we can't identity which one is select. So, when we select any button, make the selected one green

  • [ ] in the green background, make the text colour as white by replacing the existing grey colour image

  • [ ] even though we haven't selected the calendar icon, just after selecting no in repetition, below the icon it is mention invalid date ( occured when we try to update existing consultation form )

nihal467 avatar Nov 01 '22 07:11 nihal467

@khavinshankar

there are few issues need to take up for discussion in the EOD call

  • [ ] the current system and proposed system designs are different

image

  • [ ] Procedure and notes are limited to 100 character in the issue, so, allotting full individual rows for each of them, feel like waste of space. Below screenshot will give a example of space utilized by 100 character. image
  • [ ] since there is only yes/no , in the procedure section, anyone value by default kept pre-select in repetition and frequency field, without users input. For example, without filling any field in procedure section and submit the consultation field, the values in the below screenshot are by default saved by the form

image

nihal467 avatar Nov 01 '22 08:11 nihal467

@nihal467 yes, it was done by @arpancodes long back, i'm not sure even if this is relevant anymore, we already investigation, so not sure if we need procedure

khavinshankar avatar Nov 01 '22 08:11 khavinshankar

@khavinshankar as per EOD, it is been redesign similar to investigation in the consultation page

nihal467 avatar Nov 01 '22 15:11 nihal467

:wave: Hi, @arpancodes, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Nov 03 '22 15:11 github-actions[bot]

this feature has already been added

khavinshankar avatar Jan 09 '23 11:01 khavinshankar