care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Added image for locations not found

Open siddnikh opened this issue 2 years ago • 7 comments

Solves issue #3045

siddnikh avatar Jul 30 '22 23:07 siddnikh

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 30 '22 23:07 sonarqubecloud[bot]

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit bdd16c404c8417eb5a29c52edec03cbd48be8faa
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/635bbfca8297e90008304cf7
Deploy Preview https://deploy-preview-3275--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 30 '22 23:07 netlify[bot]

@siddnikh image

  • [ ] the whole page in normal view itself is stretched and we need to scroll the page down, adjust the page , in a way that we don't need to scroll the page
  • [ ] the icon doesn't feel good, take an opinion from other in EOD call or slack channel before working on the icon again

nihal467 avatar Sep 28 '22 03:09 nihal467

Hi, @${author}, This pr/issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

stale[bot] avatar Oct 08 '22 12:10 stale[bot]

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex This pr/issue has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr/issue.

stale[bot] avatar Oct 15 '22 16:10 stale[bot]

@siddnikh image

the page is having scroller in normal view, readjust the icon size and position so that, the scroller doesn't appear on the page

nihal467 avatar Oct 24 '22 12:10 nihal467

@siddnikh image

the page is still having the scroller, reduce the size of the icon and bring it little bit upward

nihal467 avatar Oct 25 '22 12:10 nihal467

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ❌ Failed (Inspect) Oct 28, 2022 at 11:42AM (UTC)

vercel[bot] avatar Oct 28 '22 11:10 vercel[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 28 '22 11:10 sonarqubecloud[bot]

@siddnikh image

the page is still having the scroller, reduce the size of the icon and bring it little bit upward

I have tested on all device dimensions on my laptop. I hope this works now. If it does not, can you tell me your screen dimensions? Thanks. @nihal467

siddnikh avatar Oct 28 '22 12:10 siddnikh

@siddnikh what is the update on this PR

nihal467 avatar Nov 23 '22 13:11 nihal467

@nihal467 https://deploy-preview-3275--care-net.netlify.app/facility/6fcc52a3-f917-4e5c-ab33-d9af2cd26a16/location here, please try this out and lmk if there still exists any issue on your side.

siddnikh avatar Nov 27 '22 09:11 siddnikh

@siddnikh image

@siddnikh marking it as team discussion required for multiple reason

  • we are moving towards careicons, is it okay to use this icon
  • does the UI looks good for approval

nihal467 avatar Jan 09 '23 11:01 nihal467

@siddnikh image

  • [ ] the icon size looks really big, make it smaller
  • [ ] the icon seem to be cropped in the bottom, doesn't look good

nihal467 avatar Feb 06 '23 11:02 nihal467

@nihal467 I will make a new PR for this, it's an old branch so I'm having trouble merging it with develop.

siddnikh avatar Feb 06 '23 18:02 siddnikh