care_fe
care_fe copied to clipboard
Added image for locations not found
Solves issue #3045
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Deploy Preview for care-egov-staging ready!
Name | Link |
---|---|
Latest commit | bdd16c404c8417eb5a29c52edec03cbd48be8faa |
Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/635bbfca8297e90008304cf7 |
Deploy Preview | https://deploy-preview-3275--care-egov-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@siddnikh
- [ ] the whole page in normal view itself is stretched and we need to scroll the page down, adjust the page , in a way that we don't need to scroll the page
- [ ] the icon doesn't feel good, take an opinion from other in EOD call or slack channel before working on the icon again
Hi, @${author}, This pr/issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex This pr/issue has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr/issue.
@siddnikh
the page is having scroller in normal view, readjust the icon size and position so that, the scroller doesn't appear on the page
@siddnikh
the page is still having the scroller, reduce the size of the icon and bring it little bit upward
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
care-storybook | ❌ Failed (Inspect) | Oct 28, 2022 at 11:42AM (UTC) |
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
@siddnikh
the page is still having the scroller, reduce the size of the icon and bring it little bit upward
I have tested on all device dimensions on my laptop. I hope this works now. If it does not, can you tell me your screen dimensions? Thanks. @nihal467
@siddnikh what is the update on this PR
@nihal467 https://deploy-preview-3275--care-net.netlify.app/facility/6fcc52a3-f917-4e5c-ab33-d9af2cd26a16/location here, please try this out and lmk if there still exists any issue on your side.
@siddnikh
@siddnikh marking it as team discussion required for multiple reason
- we are moving towards careicons, is it okay to use this icon
- does the UI looks good for approval
@siddnikh
- [ ] the icon size looks really big, make it smaller
- [ ] the icon seem to be cropped in the bottom, doesn't look good
@nihal467 I will make a new PR for this, it's an old branch so I'm having trouble merging it with develop.