care_fe
care_fe copied to clipboard
added seperate HL7 Monitor and ONVIF CAMERA condiguration page
Fixes #2811 Fixes #2810 Part of #2430
Latest changes
Added HL7 monitor page
Added ONVIF Page
Added feature to edit the preset name in the live feed
implementation video
https://www.loom.com/share/8ccdc5bf4f734fd995d11e7b07b0c166
@gigincg Added validation for IP address on both pages and fixed all minor errors.
New UI of ONVIF Camera Page
New UI of HL7 Monitor Page
@patelaryan7751 having the icon covered this much space doesn't give good look in UI, can we have a better alternative
Deploy Preview for care-egov-staging ready!
Name | Link |
---|---|
Latest commit | 765f2edef5ef4b3f2585aef926f0f6afff85cbdf |
Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/6319dcbaed347000082884c1 |
Deploy Preview | https://deploy-preview-3110--care-egov-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@patelaryan7751 Can you edit the PR and add screenshots of the new UI?
@gigincg yeah sure
Hey, @gigincg I have added the screenshots of the new UI.
@patelaryan7751
the visual is not coming up, even the configuration is done
@nihal467 i have fixed the bug its working now https://www.loom.com/share/45ff7c06755d49a19c0a58cad33b703f
@patelaryan7751 once the configuration is set, i have to manually reload the page to see the camera visual
@nihal467 I have done the changes.
LGTM
@nihal467 @patelaryan7751 why is this pr on hold?
@khavinshankar there is some api related issue @iamsdas is working on it.
@patelaryan7751 what was the (backend) issue about? I am not working on anything related to this right now. Maybe I have already merged it?
Hey @iamsdas actually the camera_type variable is required in the api so in that day Gigin told to remove the required thing as there is no need of the field. Let's discuss it one to one ?
Hey @iamsdas actually the camera_type variable is required in the api so in that day Gigin told to remove the required thing as there is no need of the field.
I made the required changes that very day.
Let's discuss it one to one?
Sure
Edit: link to PR
okay got it sorry my bad 😅 @iamsdas
@patelaryan7751 merge the latest development branch and check the Cypress test is passing or not
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells
No Coverage information
0.0% Duplication