care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

added seperate HL7 Monitor and ONVIF CAMERA condiguration page

Open patelaryan7751 opened this issue 2 years ago • 19 comments

Fixes #2811 Fixes #2810 Part of #2430

Latest changes

Added HL7 monitor page

image

Added ONVIF Page

image

Added feature to edit the preset name in the live feed

image

implementation video

https://www.loom.com/share/8ccdc5bf4f734fd995d11e7b07b0c166

patelaryan7751 avatar Jul 13 '22 10:07 patelaryan7751

@gigincg Added validation for IP address on both pages and fixed all minor errors. image

patelaryan7751 avatar Jul 13 '22 18:07 patelaryan7751

New UI of ONVIF Camera Page

Screenshot from 2022-07-14 01-18-50

New UI of HL7 Monitor Page

image

patelaryan7751 avatar Jul 13 '22 19:07 patelaryan7751

@patelaryan7751 having the icon covered this much space doesn't give good look in UI, can we have a better alternative

nihal467 avatar Jul 19 '22 12:07 nihal467

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit 765f2edef5ef4b3f2585aef926f0f6afff85cbdf
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6319dcbaed347000082884c1
Deploy Preview https://deploy-preview-3110--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 03 '22 17:08 netlify[bot]

@patelaryan7751 Can you edit the PR and add screenshots of the new UI?

gigincg avatar Aug 13 '22 08:08 gigincg

@gigincg yeah sure

patelaryan7751 avatar Aug 13 '22 09:08 patelaryan7751

Hey, @gigincg I have added the screenshots of the new UI.

patelaryan7751 avatar Aug 13 '22 09:08 patelaryan7751

@patelaryan7751 image

the visual is not coming up, even the configuration is done

nihal467 avatar Aug 15 '22 12:08 nihal467

@nihal467 i have fixed the bug its working now https://www.loom.com/share/45ff7c06755d49a19c0a58cad33b703f

patelaryan7751 avatar Aug 15 '22 20:08 patelaryan7751

@patelaryan7751 once the configuration is set, i have to manually reload the page to see the camera visual

nihal467 avatar Aug 16 '22 09:08 nihal467

@nihal467 I have done the changes.

patelaryan7751 avatar Aug 16 '22 13:08 patelaryan7751

LGTM

nihal467 avatar Aug 17 '22 12:08 nihal467

@nihal467 @patelaryan7751 why is this pr on hold?

khavinshankar avatar Sep 01 '22 08:09 khavinshankar

@khavinshankar there is some api related issue @iamsdas is working on it.

patelaryan7751 avatar Sep 01 '22 09:09 patelaryan7751

@patelaryan7751 what was the (backend) issue about? I am not working on anything related to this right now. Maybe I have already merged it?

iamsdas avatar Sep 01 '22 09:09 iamsdas

Hey @iamsdas actually the camera_type variable is required in the api so in that day Gigin told to remove the required thing as there is no need of the field. Let's discuss it one to one ?

patelaryan7751 avatar Sep 01 '22 10:09 patelaryan7751

Hey @iamsdas actually the camera_type variable is required in the api so in that day Gigin told to remove the required thing as there is no need of the field.

I made the required changes that very day.

Let's discuss it one to one?

Sure

Edit: link to PR

iamsdas avatar Sep 01 '22 10:09 iamsdas

okay got it sorry my bad 😅 @iamsdas

patelaryan7751 avatar Sep 01 '22 10:09 patelaryan7751

@patelaryan7751 merge the latest development branch and check the Cypress test is passing or not

nihal467 avatar Sep 05 '22 20:09 nihal467

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 08 '22 12:09 sonarqubecloud[bot]