care_fe
care_fe copied to clipboard
Changed leaflet location picker to gmap
Fixes #2526
⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secret in your pull request
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
757392 | Google API Key | 2cec8ae450221cabcfc5897aca1694570e538c3a | src/Common/env.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@khavinshankar the map is not working
@khavinshankar what is the PR status
Deploy Preview for care-egov-staging ready!
Name | Link |
---|---|
Latest commit | cd6a58c1225d854c3b4fa4cfeca030106eda0a57 |
Latest deploy log | https://app.netlify.com/sites/care-egov-staging/deploys/6347bcfc7f015e000812a044 |
Deploy Preview | https://deploy-preview-2921--care-egov-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
@nihal467 this won't work in the netlify deploy because the gmap api key permissions are not given for netlify sites, either we can merge this into staging (it should work in staging) and test it or we can ask mathew to add permissions to the api key to allow netlify
@gigincg what is your opinion
@nihal467 @khavinshankar Updated the restrictions to allow deploy-previews under care-egov-staging.
Tested to be working in https://deploy-preview-2921--care-egov-staging.netlify.app/
@khavinshankar
can we have a location search box in it, as we have in our current staging, in case, the GPS doesn't work out, we would be requiring a search area to type in the location.
@khavinshankar what is the status !
@mathew-alex can you please enable permission for places library in gmaps api for this key
:wave: Hi, @khavinshankar, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
@mathew-alex can you please enable permission for places library in gmaps api for this key
the permission is enabled now.
Changes made:
- added searchbox
@khavinshankar
- [ ] i can't get it, it is showing Oops
- [ ] it is always asking allow or not in the platform, which is not good, since most of our users are not tech savy
@mathew-alex can you check the permissions for gmap API
@mathew-alex can you check the permissions for gmap API
added permissions
@khavinshankar
https://deploy-preview-2921--care-egov-staging.netlify.app/ it is working on this staging, test approved
:wave: Hi, @khavinshankar, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
:wave: Hi, @khavinshankar, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.
This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication