care_fe icon indicating copy to clipboard operation
care_fe copied to clipboard

Changed leaflet location picker to gmap

Open khavinshankar opened this issue 2 years ago • 10 comments

Fixes #2526

khavinshankar avatar Jun 27 '22 09:06 khavinshankar

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae450221cabcfc5897aca1694570e538c3a src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Jun 27 '22 09:06 gitguardian[bot]

16

@khavinshankar the map is not working

nihal467 avatar Jul 03 '22 14:07 nihal467

@khavinshankar what is the PR status

nihal467 avatar Jul 31 '22 01:07 nihal467

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit cd6a58c1225d854c3b4fa4cfeca030106eda0a57
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6347bcfc7f015e000812a044
Deploy Preview https://deploy-preview-2921--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 31 '22 14:07 netlify[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 31 '22 14:07 sonarqubecloud[bot]

@nihal467 this won't work in the netlify deploy because the gmap api key permissions are not given for netlify sites, either we can merge this into staging (it should work in staging) and test it or we can ask mathew to add permissions to the api key to allow netlify

khavinshankar avatar Jul 31 '22 14:07 khavinshankar

@gigincg what is your opinion

nihal467 avatar Aug 01 '22 12:08 nihal467

@nihal467 @khavinshankar Updated the restrictions to allow deploy-previews under care-egov-staging.

Tested to be working in https://deploy-preview-2921--care-egov-staging.netlify.app/

gigincg avatar Aug 01 '22 13:08 gigincg

@khavinshankar image

can we have a location search box in it, as we have in our current staging, in case, the GPS doesn't work out, we would be requiring a search area to type in the location.

nihal467 avatar Aug 03 '22 09:08 nihal467

@khavinshankar what is the status !

nihal467 avatar Aug 23 '22 04:08 nihal467

@mathew-alex can you please enable permission for places library in gmaps api for this key image

khavinshankar avatar Sep 12 '22 02:09 khavinshankar

:wave: Hi, @khavinshankar, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

mathew-alex avatar Sep 27 '22 10:09 mathew-alex

@mathew-alex can you please enable permission for places library in gmaps api for this key image

the permission is enabled now.

mathew-alex avatar Sep 29 '22 05:09 mathew-alex

Changes made:

  • added searchbox image

khavinshankar avatar Sep 29 '22 10:09 khavinshankar

@khavinshankar image

  • [ ] i can't get it, it is showing Oops
  • [ ] it is always asking allow or not in the platform, which is not good, since most of our users are not tech savy

nihal467 avatar Oct 03 '22 08:10 nihal467

@mathew-alex can you check the permissions for gmap API image

khavinshankar avatar Oct 06 '22 07:10 khavinshankar

@mathew-alex can you check the permissions for gmap API image

added permissions

mathew-alex avatar Oct 06 '22 10:10 mathew-alex

@khavinshankar

https://deploy-preview-2921--care-egov-staging.netlify.app/ it is working on this staging, test approved

nihal467 avatar Oct 11 '22 08:10 nihal467

:wave: Hi, @khavinshankar, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Oct 11 '22 10:10 github-actions[bot]

:wave: Hi, @khavinshankar, Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions[bot] avatar Oct 13 '22 05:10 github-actions[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 13 '22 07:10 sonarqubecloud[bot]