Jul 25 '22 14:07 khavinshankar

Codecov Report

Merging #947 (a1144e1) into master (6bd66bf) will decrease coverage by 1.29%. The diff coverage is 50.66%.

:exclamation: Current head a1144e1 differs from pull request most recent head 3d04d91. Consider uploading reports for the commit 3d04d91 to get more accurate results

@@            Coverage Diff             @@
##           master     #947      +/-   ##
==========================================
- Coverage   54.02%   52.72%   -1.30%     
==========================================
  Files         182      184       +2     
  Lines        8990     8889     -101     
==========================================
- Hits         4857     4687     -170     
- Misses       4133     4202      +69

Impacted Files	Coverage Δ
care/facility/api/viewsets/patient.py	`47.90% <0.00%> (-0.34%)`	:arrow_down:
...re/facility/management/commands/scrape_icd_data.py	`0.00% <0.00%> (ø)`
care/facility/models/file_upload.py	`68.88% <0.00%> (ø)`
care/facility/models/icd.py	`0.00% <0.00%> (ø)`
care/facility/models/json_schema/asset.py	`100.00% <ø> (ø)`
care/facility/models/patient.py	`88.09% <ø> (-6.75%)`	:arrow_down:
care/facility/static_data/icd11.py	`0.00% <0.00%> (ø)`
care/users/api/viewsets/users.py	`42.94% <0.00%> (-12.90%)`	:arrow_down:
care/utils/assetintegration/onvif.py	`38.23% <ø> (+1.09%)`	:arrow_up:
care/facility/api/viewsets/file_upload.py	`48.57% <15.38%> (-2.95%)`	:arrow_down:
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Jul 25 '22 14:07 codecov-commenter

Add descriptions in all PRs! Explain the need for this feature, how its implemented and what might be affected with its addition.

Jul 25 '22 18:07 vigneshhari

This pr adds features to use the classification of diseases from ICD11 (https://icd.who.int/) Refer: https://github.com/coronasafe/care_fe/issues/2016

context: Initially, for the same thing proxying was suggested (care fe -> be -> icd.who.int) [#864] but Bodhi suggested to store the diseases directly in care db because of the reliability issues

4 endpoints are added:

GET /icd: for searching the diseases using label GET /icd/{id}: for get a specific disease by id POST /icd: for adding new disease or diseases (if needed) GET /icd/scrape (only can be accessed by admin user): for triggering celery task for scraping icd website and adding those diseases to db

Jul 26 '22 09:07 khavinshankar

OpenAPI documentation would be nice for this endpoint

Aug 25 '22 15:08 vigneshhari

Kudos, SonarCloud Quality Gate passed!