care icon indicating copy to clipboard operation
care copied to clipboard

fix:rename internal version field to _version

Open nandkishorr opened this issue 1 month ago • 2 comments

Proposed Changes

  • Renamed constructed["version"] to constructed["_version"] in EMRResource serialization to prevent overwriting the version field for models

  • Updated the version field in questionnaire json

Associated Issue

  • https://github.com/ohcnetwork/care_fe/pull/14012

Merge Checklist

  • [x] Tests added/fixed
  • [ ] Update docs in /docs
  • [x] Linting Complete
  • [ ] Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

nandkishorr avatar Nov 04 '25 07:11 nandkishorr

Codecov Report

:x: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.86%. Comparing base (fefde08) to head (0e68ee9). :warning: Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
care/emr/resources/base.py 0.00% 1 Missing :warning:
care/emr/resources/questionnaire/spec.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3343      +/-   ##
===========================================
- Coverage    53.87%   53.86%   -0.01%     
===========================================
  Files          434      434              
  Lines        19683    19683              
  Branches      2129     2129              
===========================================
- Hits         10604    10603       -1     
- Misses        9051     9052       +1     
  Partials        28       28              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 04 '25 08:11 codecov[bot]

@abhimanyurajeesh

nandkishorr avatar Nov 04 '25 11:11 nandkishorr