fixed update endpoint for organization viewset

[praffq]

Proposed Changes

• fixed minor bug with update endpoint of organization viewset

Merge Checklist

• [ ] Tests added/fixed
• [ ] Update docs in /docs
• [ ] Linting Complete
• [ ] Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Summary by CodeRabbit

• Bug Fixes
  • Restored validation to prevent organizations from being nested beyond the maximum allowed depth when creating or updating organizations. Users will now receive an error if they attempt to exceed the permitted hierarchy level.

[coderabbitai[bot]]

📝 Walkthrough

Walkthrough

The logic enforcing a maximum nesting depth for organizations was removed from the API viewset and reimplemented within the resource specification. Now, the depth validation for parent organizations occurs during resource validation rather than in the API layer, with no changes to public interfaces or method signatures.

Changes

File(s)	Change Summary
care/emr/api/viewsets/organization.py	Removed import of settings and deleted organization depth validation logic from validate_data.
care/emr/resources/organization/spec.py	Added organization depth validation to validate_parent_organization using Django settings.

Suggested reviewers

• vigneshhari

Poem

In code’s deep forest, depth once checked above,
Now moved below, with a gentle shove.
No more the viewset’s wary eye,
The spec now guards how deep roots lie.
Oh, nesting trees, beware your fate—
For specs, not views, now regulate!
🌳🦉

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 483112651c68252af6e6da8c63fb3b2b288e4067 and 0f0a22c6c507e6c6c9bec3235958ad41972d2364.

📒 Files selected for processing (1)

• care/emr/api/viewsets/organization.py (0 hunks)

💤 Files with no reviewable changes (1)

• care/emr/api/viewsets/organization.py

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Test / Test
• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

🧪 Generate Unit Tests

• [ ] Create PR with Unit Tests
• [ ] Post Copyable Unit Tests in Comment
• [ ] Commit Unit Tests in branch prafful/bugs/organization-viewset

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 51.19%. Comparing base (05dd61f) to head (0f0a22c).

Files with missing lines	Patch %	Lines
care/emr/resources/organization/spec.py	28.57%	5 Missing :warning:
care/emr/api/viewsets/facility_organization.py	0.00%	3 Missing :warning:

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3083   +/-   ##
========================================
  Coverage    51.18%   51.19%           
========================================
  Files          251      251           
  Lines        11403    11394    -9     
  Branches      1284     1283    -1     
========================================
- Hits          5837     5833    -4     
+ Misses        5545     5540    -5     
  Partials        21       21           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[praffq]

@coderabbitai full review

[coderabbitai[bot]]

✅ Actions performed

Full review triggered.