care icon indicating copy to clipboard operation
care copied to clipboard

Improved GitHub Actions pipeline: parallel ARM and x86 builds

Open Alokih opened this issue 1 year ago • 2 comments

Proposed Changes

  • This PR improves the GitHub Actions pipeline by running ARM and x86 builds in parallel using the matrix strategy.

Associated Issue

  • Fixes #1803

Testing:

  • Tested locally using Docker Buildx with linux/amd64 and linux/arm64 platforms.
  • Verified that the builds are running in parallel.

Screenshot from 2024-10-22 00-22-03

Screenshot from 2024-10-22 01-02-24

  • Here is a log output showing parallel builds:

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Alokih avatar Oct 21 '24 19:10 Alokih

Hey @rithviknishad sir, even though builds are running parallely when I am testing the workflows on my repo in both branches develop & PR branch I am getting almost same time duration

Screenshot from 2024-10-22 01-32-13

ghost avatar Oct 21 '24 20:10 ghost

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.00%. Comparing base (8bac44a) to head (580847a). Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2554   +/-   ##
========================================
  Coverage    70.00%   70.00%           
========================================
  Files          198      198           
  Lines        11662    11662           
  Branches      1605     1605           
========================================
  Hits          8164     8164           
  Misses        3107     3107           
  Partials       391      391           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 21 '24 22:10 codecov[bot]

@sainak take a look

vigneshhari avatar Oct 30 '24 09:10 vigneshhari

@Alokih thanks for the pr however this is not the correct way to publish multiplatform images, and from my research I found that buildkit already does some parallelization during builds, so the benefits of matrix builds are negligible in the case of just 2 platforms.

sainak avatar Nov 04 '24 09:11 sainak

Ok @sainak sir

ghost avatar Nov 04 '24 10:11 ghost