care icon indicating copy to clipboard operation
care copied to clipboard

Clean up asset classes

Open praffq opened this issue 1 year ago • 1 comments

Proposed Changes

  • Updated assert classes to improve option handling

Associated Issue

  • Fixes #2435

Architecture changes

  • Remove this section if not used

Merge Checklist

  • [x] Tests added/fixed
  • [ ] Linting Complete

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

praffq avatar Sep 24 '24 11:09 praffq

blocking for

  • #2483

sainak avatar Sep 24 '24 13:09 sainak

Codecov Report

Attention: Patch coverage is 60.46512% with 17 lines in your changes missing coverage. Please review.

Project coverage is 69.37%. Comparing base (8d5e701) to head (f75908a). Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
care/utils/assetintegration/onvif.py 20.00% 8 Missing :warning:
care/utils/assetintegration/hl7monitor.py 40.00% 3 Missing :warning:
care/utils/assetintegration/ventilator.py 40.00% 3 Missing :warning:
care/utils/assetintegration/base.py 90.00% 2 Missing :warning:
care/facility/api/viewsets/asset.py 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2494      +/-   ##
===========================================
+ Coverage    69.20%   69.37%   +0.17%     
===========================================
  Files          211      212       +1     
  Lines        11942    11961      +19     
  Branches      1208     1208              
===========================================
+ Hits          8264     8298      +34     
+ Misses        3302     3287      -15     
  Partials       376      376              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 04 '24 09:11 codecov[bot]

@sainak made the changes. Please check

praffq avatar Nov 04 '24 13:11 praffq