care
care copied to clipboard
Disable the Bed List of Already occupied Beds (back-end change)
Proposed Changes
- Brief of changes made.
- added a new filter not_occupied_by_hl7_monitor when true filter bed already occupied by hl7 monitors
Associated Issue
Fixes link
Architecture changes
- Remove this section if not used
Merge Checklist
- [ ] Tests added/fixed
- [ ] Update docs in
/docs
- [x] Linting Complete
- [ ] Any other necessary step
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins
LGTM, but there is no need to make the filter specific to hl7 monitor right? We can make a filter
not_occupied_by_asset_type
which accepts the asset type to exclude.This way it'd work for excluding ONVIF cameras or ventilators too if needed in the future.
yes makes sense and is also scalable
@rithviknishad i have added a test
Codecov Report
Attention: Patch coverage is 60.00000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 62.71%. Comparing base (
51ce81e
) to head (8f3b343
). Report is 90 commits behind head on develop.
:exclamation: Current head 8f3b343 differs from pull request most recent head 220f127
Please upload reports for the commit 220f127 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
care/facility/api/viewsets/bed.py | 60.00% | 1 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #2116 +/- ##
===========================================
+ Coverage 62.20% 62.71% +0.51%
===========================================
Files 221 237 +16
Lines 12204 13035 +831
Branches 1742 1853 +111
===========================================
+ Hits 7591 8175 +584
- Misses 4305 4522 +217
- Partials 308 338 +30
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM @rithviknishad @sainak can you fix the lint issue