care icon indicating copy to clipboard operation
care copied to clipboard

Fixed: Added occupation field for text support

Open aeswibon opened this issue 1 year ago • 2 comments

Updates

  • [x] Fixes #806
  • [x] Removed Occupation Choices from PatientMetaInfo model
  • [x] Altered the occupation field from IntegerField to CharField
  • [x] Removed occupation field as ChoiceField from PatientMetaInfoSerializer
  • [x] Added migration to alter the schema for occupation field
  • [x] Added migration to retain all the data

aeswibon avatar Oct 09 '22 04:10 aeswibon

Codecov Report

Base: 56.06% // Head: 56.02% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (c4a376a) compared to base (0beaa72). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
- Coverage   56.06%   56.02%   -0.05%     
==========================================
  Files         175      175              
  Lines        8629     8620       -9     
  Branches     1462     1475      +13     
==========================================
- Hits         4838     4829       -9     
  Misses       3739     3739              
  Partials       52       52              
Impacted Files Coverage Δ
care/facility/api/serializers/patient.py 55.81% <100.00%> (-0.21%) :arrow_down:
care/facility/models/patient.py 92.59% <100.00%> (-0.27%) :arrow_down:
care/users/api/viewsets/change_password.py 61.53% <0.00%> (+1.53%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 09 '22 04:10 codecov-commenter

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Oct 28 '22 10:10 sonarcloud[bot]

@vigneshhari can you review it

nihal467 avatar Feb 13 '23 14:02 nihal467

@cp-Coder add test cases

sainak avatar Jul 20 '23 16:07 sainak

Will open a new PR

aeswibon avatar Aug 07 '23 08:08 aeswibon