cwa-website icon indicating copy to clipboard operation
cwa-website copied to clipboard

Fix FAQ Link #vac_cert_booster

Open brifemu opened this issue 2 years ago • 2 comments

This PR fixes #3073. We have replaced the redirect link from "vac_cert_booster" to "vac_booster_basics"


Internal Tracking ID: EXPOSUREAPP-14102

brifemu avatar Oct 13 '22 11:10 brifemu

Please don't merge this until I have an opportunity to check it. I'm not sure that it fixes the underlying problem and it may break the Cypress tests.

MikeMcC399 avatar Oct 13 '22 12:10 MikeMcC399

Redirecting #vac_cert_booster to #vac_booster_basics (an individual article, not section header) works around the reported issue, however it does not address the underlying issue, which is a fault in displaying a section on a mobile device which has been requested through a redirect.

The underlying problem continues to exist and can be seen by selecting https://www.coronawarn.app/en/faq/#vac_booster. This redirects to https://www.coronawarn.app/en/faq/#vac_cert and displays incorrectly on a mobile device in portrait mode.

MikeMcC399 avatar Oct 15 '22 09:10 MikeMcC399

@MikeMcC399

Redirecting #vac_cert_booster to #vac_booster_basics (an individual article, not section header) works around the reported issue, however it does not address the underlying issue, which is a fault in displaying a section on a mobile device which has been requested through a redirect.

The underlying problem continues to exist and can be seen by selecting https://www.coronawarn.app/en/faq/#vac_booster. This redirects to https://www.coronawarn.app/en/faq/#vac_cert and displays incorrectly on a mobile device in portrait mode.

We understand that this does not fix the underlying technical issue but we would want to merge this now anyway to "fix this" for now. As the technical issue remains, we will still look into it and fix it soon.


Internal Tracking ID: EXPOSUREAPP-14141

larswmh avatar Oct 17 '22 05:10 larswmh

It seems that this PR was merged without running the Cypress test suite. https://github.com/corona-warn-app/cwa-website/blob/master/README.md#testing says "To minimize the occurrence of errors we would ask you to perform all tests when contributing to our repository"

  • See issue #3146

MikeMcC399 avatar Oct 17 '22 17:10 MikeMcC399