cwa-quicktest-onboarding icon indicating copy to clipboard operation
cwa-quicktest-onboarding copied to clipboard

Url path for qrcode https://s.coronawarn.app?v=1 should be https://s.coronawarn.app/?v=1

Open dmr opened this issue 4 years ago • 3 comments

Describe the bug

In the documentation the qrcode-url is described:

https://github.com/corona-warn-app/cwa-quicktest-onboarding/wiki/Anbindung-der-Partnersysteme#erstellung-von-qr-codes-f%C3%BCr-corona-warn-app

image

From our perspective

https://s.coronawarn.app?v=1

should be

https://s.coronawarn.app/?v=1

Expected behaviour / Possible Fix

https://s.coronawarn.app?v=1

should be

https://s.coronawarn.app/?v=1

Additional context

A library in our backend is causing problems because without the "/" the url is not considered a correct url.

dmr avatar Jul 13 '21 10:07 dmr

@dmr Do you have any chance to test, whether importing tests into CWA work both for Android and iOS when using a) deeplinks and b) QR code scan with the proposed format/structure https://s.coronawarn.app/?v=1 is successful? I do agree that the URL format would be in line with conventions when using "/" after the TLD. But I'm uncertain if both OS know this for deeplinks, and their QR code scanners for QR codes.

vaubaehn avatar Jul 14 '21 15:07 vaubaehn

We tested it on iOS and it works there.

I would assume that the browser will convert it to a real url before any redirect happens but we didn't test on Android yet.

I think the more problematic part could be the "#"-part but I'm not afraid about the first url parts from my experience with urls.

dmr avatar Jul 14 '21 15:07 dmr

but we didn't test on Android yet

We had some reports that iOS and Android behave differently according to their QR scanner dependencies. I don't know whether Android also might make a difference in deeplink handling here, too.

I think the more problematic part could be the "#"-part

The "#" is necessary to not expose the payload "to the internet" in case the link is opened via a common browser, so it can't be changed.

vaubaehn avatar Jul 14 '21 15:07 vaubaehn