cwa-documentation icon indicating copy to clipboard operation
cwa-documentation copied to clipboard

"Kontakt-Tagebuch": Deleting a person is deleting all contacts w that person

Open dideldei opened this issue 3 years ago • 6 comments

Avoid duplicates

  • [+] Bug is not mentioned in the FAQ
  • [unknown] Bug affects both Android and iOS, for specific issues / questions that apply only to one operating system, please raise them in the respective repositories:
  • [+] Bug is not already reported in another issue

Technical details

  • Device name: iPhone12mini
  • iOS/Android version: 14.7
  • App version: 2.5.1 (1)

Describe the bug

Maybe it is not a bug in programmers' thinking, but it definitly is a bug in regards of data integrity and community protection. When deleting a person in "Kontakt-Tagebuch" (e.g. because you will not meet the person in the nearer future) it delets all the contacts you had in the past with that person. So data about these contacts will not be sent to local health authoritis in case of an infection and you choose to share the data.

Steps to reproduce the issue

  1. Go to "Tagebuch"
  2. Add a person
  3. Add contacts w that person
  4. Delete person.
  5. All contacts (w that person) are gone.

Expected behaviour

A contact w person should no disappear when deleting the person, at least not before the end of incubation time since the last contact to that person.

Possible Fix

Depending on the current implementation: deleting a person should not be immediate, but it should be "invisible" or greyed out as a person and contacts should still be visible and in the database for 14d. Or: Person and Contact should be more "independent" objects form each other. "Contact" should be able to store all necessary data that is valueable to inform local authorities about risky contacts.

dideldei avatar Jul 30 '21 14:07 dideldei

@dideldei

I'm sure this is the intended behavior. The pop-up you see before finally deleting a person also says that this will delete all entries of this person from the contact journal.

So I would not consider this as a bug but as a feature request and therefore suggest to open an issue in the wishlist repository.

Ein-Tim avatar Jul 30 '21 14:07 Ein-Tim

Thank you for your answer and suggestion. This might be intended behavior because it is easy to implement, but it still is a bug, because it makes the user responsible for a clean data basis in a way only computers can keep a databbase clean. Implicitly it says: When you want to delete a person you have to count the days from your last contact up to 14 days and then remember to delete the person. Poor object design should not cause that kind of app behaviour.

dideldei avatar Jul 30 '21 14:07 dideldei

@dideldei

  • There is another wishlist item related to what you are discussing. See https://github.com/corona-warn-app/cwa-wishlist/issues/405.

MikeMcC399 avatar Jul 30 '21 15:07 MikeMcC399

Also related: https://github.com/corona-warn-app/cwa-wishlist/issues/322

Ein-Tim avatar Jul 30 '21 15:07 Ein-Tim

A possible "fix" or an enhancement for this issue here could also be, to change the default behaviour: By default only the person is deleted, not the contacts. A pop-up dialog could ask "Wollen Sie diese Person wirklich aus der Personen-Liste entfernen?" and offer an additional check-box "auch alle Begegnungen aus dem Tagebuch entfernen".

vaubaehn avatar Jul 30 '21 16:07 vaubaehn

The Open-Source-Team should decide how to proceed with this issue. As of now, it just lays around without any process for over half a year. Mirroring it to JIRA would definitely make sense, I think.

Ein-Tim avatar Apr 18 '22 17:04 Ein-Tim