cwa-app-ios icon indicating copy to clipboard operation
cwa-app-ios copied to clipboard

UI: Overlapping text while creating Rapid Test Profile

Open Ein-Tim opened this issue 3 years ago • 23 comments

Avoid duplicates

  • [X] Bug is not mentioned in the FAQ
  • [X] Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
  • [X] Bug is not already reported in another issue

Technical details

  • Device name: iPhone 6s
  • iOS version: iOS 14.5.1
  • App version: 2.2.1

Describe the bug

While creating the rapid test profile it is possible that the headline "Rapid Test Profile" overlaps with the information text below.

Screenshot

Steps to reproduce the issue

  1. Open the Corona-Warn-App
  2. Click on "Next Steps" inside of the "Register your Test" box
  3. Click on "Create Rapid Test Profile"
  4. Directly click into the field "Street and House Number"
  5. See the overlapping test

Expected behaviour

The headline should disappear (get to the top) as when you scroll further down.


Internal Tracking ID: EXPOSUREAPP-7295

Ein-Tim avatar May 14 '21 20:05 Ein-Tim

Not reproducible on iPhone SE 1 iOS 14.5.1 CWA 2.2.1

jucktnich avatar May 15 '21 07:05 jucktnich

@jucktnich Quite sure this is device specific. I assume that this affects all iPhones which have the screen size of the iPhone 6.

Ein-Tim avatar May 15 '21 07:05 Ein-Tim

Ok Just wanted to be sure, it is not on small screen sizes.

jucktnich avatar May 15 '21 07:05 jucktnich

Not reproducible on iPhone 6s iOS 14.4 CWA 2.2.1

dsarkar avatar May 15 '21 07:05 dsarkar

On iPhone SE, the title is at the start in the header on iPhone 6 not, seems like this is the problem

jucktnich avatar May 15 '21 07:05 jucktnich

font size?

dsarkar avatar May 15 '21 07:05 dsarkar

@Ein-Tim @jucktnich ok, happens with medium font size only, and only tapping in "Strasse"? @Ein-Tim Correct?

dsarkar avatar May 15 '21 07:05 dsarkar

Btw Still not reproducible on iPhone SE 1

jucktnich avatar May 15 '21 07:05 jucktnich

Internal Tracking ID: EXPOSUREAPP-7295

dsarkar avatar May 15 '21 08:05 dsarkar

@dsarkar

ok, happens with medium font size only, and only tapping in "Strasse"?

Yes, correct.

Ein-Tim avatar May 15 '21 08:05 Ein-Tim

@Ein-Tim Thanks for confirming, that is also what I can reproduce. Internally reported that way. Enjoy weekend!

dsarkar avatar May 15 '21 08:05 dsarkar

I can reproduce this on the simulator on the current development branch (pre-release) as of today (06 Sept 2021, branch release/2.10.x, commit a43ff5a96f16ec695312ad050f8276bfc898874e) with the following sequence:

  • precondition: no RAT profile available
  • from Home tab, select test management
  • scroll down and select 'create RAT profile'
  • the form shows with normal title
  • scroll down to reveal the large title
  • select field "Strasse und Hausnummer"
  • the keyboard appears and pushes the form up a bit so that the selected field is still visible
  • but the large title remains and overlaps with the text.

cwa newest development / iOS 14.3 / iPhone SE

Simulator Screen Shot - iPhone SE (2nd generation) - 2021-09-06 at 19 25 40

ndegendogo avatar Sep 06 '21 17:09 ndegendogo

I volunteer 😎

ndegendogo avatar Sep 06 '21 17:09 ndegendogo

Thanks @ndegendogo! 🚀

Ein-Tim avatar Sep 06 '21 17:09 Ein-Tim

In the same scenario, but with a device with a higher screen (like iPhone 8), we see a similar, although weaker effect
(simulator / development branch as of today / iOS 14.3 / iPhone 8)

Simulator Screen Shot - iPhone 8 - 2021-09-06 at 23 25 06

ndegendogo avatar Sep 06 '21 21:09 ndegendogo

And it does not occur on iPhone 6 / iOS 12.5.3. In that configuration the modal views are presented with full screen height, whereas the newer iOS versions have a slightly reduced screen height, which results in a slightly different layout.

ndegendogo avatar Sep 06 '21 21:09 ndegendogo

The layout constraints in the animation when the keyboard appears (a) look differently than in a scrolling-up animation (b). (a) the title remains in-place, and the form moves up towards the title, and even overlapping it. (b) the form moves up together with the title, they keep constant distance.

ndegendogo avatar Sep 06 '21 22:09 ndegendogo

Same layout issue occurs with iOS 13.7. Tested on simulator with iPhone SE.

ndegendogo avatar Sep 07 '21 22:09 ndegendogo

@ndegendogo Is the root cause of this issue here related to another issue you fix with https://github.com/corona-warn-app/cwa-app-ios/pull/3511?

dsarkar avatar Sep 16 '21 15:09 dsarkar

@dsarkar no, this is different (and originally I had hoped the same...) 😅

Actually, I think I have understood roughly what is going on. I am not sure that I already understand the root cause; and I have not yet found a working solution.

So, maybe I share my insights so far.

In the scenario, the following happens:

  • user taps a field of the form
  • keyboard starts to appear
  • this triggers the form to scroll up, so that the field-to-be-entered is on the visible part of the screen and above the keyboard.
  • the scrolling is animated, and the animation is synchronized with the keyboard.

All this is nicely implemented here But now the form moves up so far that the navigation bar is supposed to shrink. Only the navigation bar is not aware of this, and stays large.

And now I am guessing wildly: 🙃

  • maybe the navigation bar misses a trigger to re-layout itself? 🤷
  • maybe the layout constraints are setup wrong? 🤷
  • maybe the wrong property is animated? 🤷

ndegendogo avatar Sep 16 '21 18:09 ndegendogo

@ndegendogo OK, thanks for the insight! I will forward this to the internal ticket for the developers.

dsarkar avatar Sep 17 '21 10:09 dsarkar

This happens also on devices with small screen like SE first generation. Click in the field for the surname. See screenshot.

iPhone SE first generation (simulator) / iOS 15.0 (simulator) / cwa latest on branch release/2.15.x as of Nov 04

Simulator Screen Shot - iPhone SE (1st generation) - 2021-11-05 at 17 36 33

ndegendogo avatar Nov 05 '21 16:11 ndegendogo

This issue is still not fixed.

Ein-Tim avatar Apr 13 '22 13:04 Ein-Tim

FYI PR: https://github.com/corona-warn-app/cwa-app-ios/pull/5014

dsarkar avatar Jan 23 '23 18:01 dsarkar

I can confirm that this has been fixed with version 3.1, and I'm therefore closing this issue as completed.

Ein-Tim avatar Feb 27 '23 16:02 Ein-Tim

🎉

ndegendogo avatar Feb 27 '23 19:02 ndegendogo