cwa-app-ios
cwa-app-ios copied to clipboard
corona-warn-app
Add edit button in contact diary where user selects entries
Avoid duplicates
- [x] This issue has not already been raised before
- [x] If you are proposing a new feature, please do so in CWA-Wishlist
Current Implementation
Currently the only way to edit the list of locations and people is in the contact diary's main view via the context menu in the upper right corner.
Suggested Enhancement
Basically all list views in iOS feature an edit button in the top corner so the user might expect one in this view as well, but then needs to go back to the parent view to change or delete entries. Therefore I would suggest adding this button for calling the edit view directly.
Expected Benefits
The user can directly edit all the entries in the same view where he also chooses them, making editing more quickly and bringing it on par with basically all list views in iOS.
Internal Tracking ID: EXPOSUREAPP-3034 Internal Tracking ID: EXPOSUREAPP-5495
Related Issue: https://github.com/corona-warn-app/cwa-wishlist/issues/334
All issues reg. the contact journal: https://github.com/corona-warn-app/cwa-wishlist/issues/310
@stefan-schoene Thanks for you suggestion.
Internal Tracking ID: EXPOSUREAPP-3034 Internal Tracking ID: EXPOSUREAPP-5495
We would like to do this together @m-seidel. Can you please assign us to the issue?
@cornelius-behrend @m-seidel You would like to provide a PR? If so, I will cross-check with developers. Thanks. Best wishes, DS
Corona-Warn-App Open Source Team
@dsarkar yes, we would like to add a PR for that if the issue was not already tackled. We would appreciate if you could check it :)
@cornelius-behrend @m-seidel OK, I will check if they would be interested in such a PR. However, they might not merge it, at the end, and this can have different reasons, e.g. quality of the code, rejected by the stakeholders, or other reasons. The are PRs from the community that have been merged, but not all of them if there was the need of major changes or quality issues or for other reasons. Stand by, I will com back to you. Thanks.
Corona-Warn-App Open Source Team
@dsarkar thank you! We're doing this as part of the Staffbase hackathon. So either way we learned something or we have contributed to the project which both is fine :)
@cornelius-behrend @m-seidel nice! Did you implement that for Android, or iOS, or even both?
I'm so free and post the link to the branch of @m-seidel & @cornelius-behrend here: https://github.com/m-seidel/cwa-app-ios/tree/feature/2196-add-edit-button-in-contact-diary
Also a huge thanks from my side! Hope that this makes it into the app!
@Ein-Tim Thanks for posting the repo link! :) We're currently focussing on the iOS since we only have 2 days @ndegendogo
@ndegendogo @Ein-Tim @cornelius-behrend @m-seidel
Typically the stakeholders insist on feature parity for both OS. However, we will see, if there might be an exception, or if this PR triggers that the feature will be developed also in Android soon.
Two comments from my side:
-
A (new) user could think that the edit button is to remove the person/place for the day, and not from the whole contact diary. Thus, I would suggest that the warning which now pops up when you delete a person or a place should definitely also be there. This is something that should be implemented from the beginning on.
-
We'll see more similar list views in the upcoming CWA version 2.0. The "My Check-Ins" screen (reachable by tapping on "Check In" on the Tab bar) & the "My QR Codes" screen (reachable by tapping on "Create QR Code" on the start screen). These views should also have this edit button. This is something that can also be implemented later.
Edit: Just build the branch locally, point 1 is already implemented! Great work @cornelius-behrend @m-seidel!
The story is currently described internally the following way:
As a user I would like to use commonly used ways of editing a person or place entry directly.
- tap and hold on an entry to open a selection to edit or delete
- swipe to delete
- add a pencil icon to edit
- add a bin icon to delete
@dsarkar
- [ ] tap and hold on an entry to open a selection to edit or delete
- [x] swipe to delete
- [ ] add a pencil icon to edit
- [x] add a bin icon to delete
I think 1 and 3 can be easily added as well. If you decide to have this as a PR, we will finish the task by adding this as well as fixing the remaining bugs and add tests.
This is what we did so far:
@dsarkar @heinezen
Could you give us feedback if the PR from @cornelius-behrend & @m-seidel would be accepted? It would be sad if this opportunity is not taken to get this create enhancement into the app.
@Ein-Tim see my latest comment in related issue: https://github.com/corona-warn-app/cwa-wishlist/issues/334. Nothing being worked on currently. As mentioned above, amongst others, stakeholders acceptance, quality of code and maintaining feature parity between Android and iOS are factors in such decisions.
@Ein-Tim @cornelius-behrend @m-seidel
Just to be clear, the dev team would review a community PR for this and will likely merge it if it is accepted and passes the CI checks. Contributions are welcome here. The RKI and other stakeholders might require the same feature for both platforms, but that shouldn't stop anyone from contributing.
Corona-Warn-App Open Source Team
@cornelius-behrend @m-seidel
Will you follow up with a PR? It would be a pity if these great changes just get lost!