cwa-app-android icon indicating copy to clipboard operation
cwa-app-android copied to clipboard

Published 20 hours ago • verified publisher icon corona-warn-app

Missing guidance about the choice of branch for PR submitters

Open MikeMcC399 opened this issue 3 years ago • 3 comments

The CONTRIBUTING guide and the linked pull_request_template do not mention how to choose a branch when submitting a PR.

Suggestion

Add some guidance about how to choose the most appropriate branch when submitting a PR.

MikeMcC399 avatar Aug 01 '22 14:08 MikeMcC399

FYI: The iOS https://github.com/corona-warn-app/cwa-app-ios/blob/release/2.26.x/CONTRIBUTING.md includes the following PR checklist, which includes the hint to branch from the latest release branch.

image

Ein-Tim avatar Aug 01 '22 14:08 Ein-Tim

  • For some reason the guidance was removed in PR #https://github.com/corona-warn-app/cwa-app-android/pull/1386 in Oct 2020.

MikeMcC399 avatar Aug 01 '22 15:08 MikeMcC399

@MikeMcC399 I think the problem was that the instruction was to branch from the dev branch, which existed in the early phase of this project, but was later replaces by the release branches. I wonder why the statement wasn't corrected but the whole checklist removed.

Ein-Tim avatar Aug 01 '22 15:08 Ein-Tim

PR: https://github.com/corona-warn-app/cwa-app-android/pull/5554

mtwalli avatar Sep 08 '22 12:09 mtwalli