cwa-app-android icon indicating copy to clipboard operation
cwa-app-android copied to clipboard

Published 20 hours ago • verified publisher icon corona-warn-app

Support Material You themed icons

Open thoweber opened this issue 3 years ago • 6 comments

Avoid duplicates

  • [X] This enhancement request has not already been raised before
  • [X] Enhancement request is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in CWA-Wishlist
  • [x] If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

The default CWA icon is shown on the home screen

Suggested Enhancement

When themed icons are activated, a themed version should be displayed.

<adaptive-icon>
  ...
  <monochrome android:drawable=""/>
  ...
</adaptive-icon>

Expected Benefits

Improves the overall UX for users of Material You. Should not be too difficult to implement, but is of course of low priority

thoweber avatar Jul 28 '22 20:07 thoweber

  • Related issue: https://github.com/corona-warn-app/cwa-app-android/issues/5118

Ein-Tim avatar Jul 29 '22 04:07 Ein-Tim

@thoweber

  • Are you are referring to Themed app icons available with Android 13 beta?

  • You mentioned also Material You, which is equivalent to Material Design 3. For Material You there are some comments in https://github.com/corona-warn-app/cwa-app-android/issues/5119 concerning what was implemented for CWA Android 2.21.

MikeMcC399 avatar Jul 31 '22 10:07 MikeMcC399

@MikeMcC399 yes, I am referring to themed app icons only, as the design team already decided against using color themes in the app

thoweber avatar Jul 31 '22 11:07 thoweber

@thoweber

I guess this might also mean that CWA would need to explicitly support Android 13. https://developer.android.com/about/versions/13 says: "Beta 4 is the last update before the official Android 13 release, coming in the weeks ahead."

Edit: Android 13 is now released - see https://android-developers.googleblog.com/2022/08/android-13-is-in-aosp.html.

MikeMcC399 avatar Aug 04 '22 18:08 MikeMcC399

@MikeMcC399

This will only work with Android 13 and up, but as far as I have understood things, it is a matter of amending the app's adaptive icons (CWA has already defined adaptive icons in Corona-Warn-App/src/main/res/mipmap-anydpi-v26 But I am not an Android dev though

https://developer.android.com/about/versions/13/features#themed-app-icon-specs

thoweber avatar Aug 04 '22 18:08 thoweber

  • Dependent on enhancement request https://github.com/corona-warn-app/cwa-app-android/issues/5469

MikeMcC399 avatar Aug 17 '22 13:08 MikeMcC399

Please see https://github.com/corona-warn-app/cwa-app-android/issues/5469#issuecomment-1371936091

mtwalli avatar Jan 05 '23 09:01 mtwalli