cwa-app-android icon indicating copy to clipboard operation
cwa-app-android copied to clipboard

Move Trace Location strings to event_registration_strings

Open Ein-Tim opened this issue 4 years ago • 3 comments

Avoid duplicates

  • [X] This enhancement request has not already been raised before
  • [X] Enhancement request is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in CWA-Wishlist
  • [X] If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

The most strings for the event registration are stored in https://github.com/corona-warn-app/cwa-app-android/blob/release/2.0.x/Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml (German as example, also applies to all other languages). But there are also some strings that are stored in https://github.com/corona-warn-app/cwa-app-android/blob/release/2.0.x/Corona-Warn-App/src/main/res/values-de/strings.xml (see f.e. Lines 1948 - 1994 in German strings).

Suggested Enhancement

Move all event-registration related strings into event_registration_strings.xml.

Expected Benefits

Cleaner code - things are easier to find.


Internal Tracking-ID: EXPOSUREAPP-6993

Ein-Tim avatar Apr 24 '21 18:04 Ein-Tim

@Ein-Tim

Thank you. We have raised this internally: EXPOSUREAPP-6993


Corona-Warn-App Open Source Team

heinezen avatar May 02 '21 15:05 heinezen

@mtwalli

Hey Mohamed, maybe you could check this issue. If the team does not want to do that, please let us know and close this issue.

Ein-Tim avatar Jun 05 '22 14:06 Ein-Tim

@Ein-Tim , The issue is still valid , the ticket is medium, it has low priority atm

mtwalli avatar Jun 07 '22 10:06 mtwalli

  • PR #5541 addresses this issue

Ein-Tim avatar Sep 07 '22 08:09 Ein-Tim

@Ein-Tim I think this issue can be closed now, since this was mainly a dev task and it does not affect end users no need to wait until 2.27 is shipped . do you agree? You can refer to https://github.com/corona-warn-app/cwa-app-android/pull/5564 to see that other languages have updated too

mtwalli avatar Sep 16 '22 10:09 mtwalli