cwa-app-android
cwa-app-android copied to clipboard
Move Trace Location strings to event_registration_strings
Avoid duplicates
- [X] This enhancement request has not already been raised before
- [X] Enhancement request is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in CWA-Wishlist
- [X] If you are proposing a new feature, please do so in CWA-Wishlist
Current Implementation
The most strings for the event registration are stored in https://github.com/corona-warn-app/cwa-app-android/blob/release/2.0.x/Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml (German as example, also applies to all other languages). But there are also some strings that are stored in https://github.com/corona-warn-app/cwa-app-android/blob/release/2.0.x/Corona-Warn-App/src/main/res/values-de/strings.xml (see f.e. Lines 1948 - 1994 in German strings).
Suggested Enhancement
Move all event-registration related strings into event_registration_strings.xml.
Expected Benefits
Cleaner code - things are easier to find.
Internal Tracking-ID: EXPOSUREAPP-6993
@Ein-Tim
Thank you. We have raised this internally: EXPOSUREAPP-6993
Corona-Warn-App Open Source Team
@mtwalli
Hey Mohamed, maybe you could check this issue. If the team does not want to do that, please let us know and close this issue.
@Ein-Tim , The issue is still valid , the ticket is medium, it has low priority atm
- PR #5541 addresses this issue
@Ein-Tim I think this issue can be closed now, since this was mainly a dev task and it does not affect end users no need to wait until 2.27 is shipped . do you agree? You can refer to https://github.com/corona-warn-app/cwa-app-android/pull/5564 to see that other languages have updated too