Jonas Hörsch

Results 160 comments of Jonas Hörsch

All `tox` envs work fine for me here, except that i did not try `tox -e pr`, but i'm on a fairly recent python mac os x install (3.10.10).

On a different note, i got rid of `bumpversion` and `check-manifest` in favour of `setuptools_scm` and replaced `isort` and `flake8` with `ruff` and `black` over at https://github.com/coroa/python-project-skeleton/tree/use-automatic-versioning . Since this...

> Also, I disagree with placing all configurations in the `pyproject.toml`, as is the current tendency. For example, I prefer `flake8` and `isort` parameters in `tox.ini` where they are used...

Also stumbled over this limitation today! Any new recommendations since last year?

@BashCloud @hrushi-thorat Maybe you are not aware of the implications. It effectively means: nobody may modify, copy use your code without fearing legal implications. *nobody* includes **you**, since you are...

Seeing this also with [attrs](https://www.attrs.org/) classes on python 3.11

`s.overlaps` would not solve the example use case, would it? Since i explicitly wanted to transport the meaning of `~s.c("value")`, ie. shared columns except "value". The only thing that is...

> > s.overlaps would not solve the example use case, would it? > > Sure, alone it would not. I am suggesting that that is a _composable_ piece that when...

Ok, I quickly put up two similar draft implementations: 1. #8027 implements the mentioned `join` "selector" with the different modes 2. #8028 adds just a simple function `expand_overlap` to the...

I had a quick look at compatibility with `the-epic-split` on Saturday and i think the equivalent of hooking `expand_overlap` (or `JoinSelector.expand`) into `_clean_join_predicates` there is to modify https://github.com/ibis-project/ibis/blob/e851796fee255b78afc57c69748422d75dae6af1/ibis/expr/types/joins.py#L97-L130 and include...