dicomParser icon indicating copy to clipboard operation
dicomParser copied to clipboard

If Transfer Syntax Tag(or other tag) already exist, Do not override.

Open suoc opened this issue 5 years ago • 3 comments

To resolve #137

suoc avatar Mar 19 '20 13:03 suoc

Coverage Status

Coverage decreased (-0.008%) to 52.751% when pulling a9d67c4c65d5b3246b1ef4ae989d79ac092ad5ac on suoc:master into c7caa5994a4cc9bf043fc8fdce8ff4b4dc1be434 on cornerstonejs:master.

coveralls avatar Mar 19 '20 13:03 coveralls

@suoc, while this resolves your issue, I'm not sure it makes sense as a check for standards compliant DICOM files?

dannyrb avatar Mar 26 '20 03:03 dannyrb

Yes you are right, But the real world really exist a lots of this problem, I think we should consider this to solve real world error.

suoc avatar Mar 26 '20 03:03 suoc

I'm going to close this in agreement with @dannyrb. This library is focusing on standards-compliant DICOM parsing. Feel free to fork or wrap the methods provided in this repo to handle any non-compliant data you have.

yagni avatar Oct 10 '22 21:10 yagni