cornerstoneWebImageLoader
cornerstoneWebImageLoader copied to clipboard
feat: Add support for loading images with blob urls
Register blob
as scheme instead of blob:http
or blob:https
because
cornerstone-core splits on :
and uses the first part as the scheme. So,
if provided a url blob:https://github.com/test-id
it will consider blob
as the scheme instead of blob:https
.
Closes https://github.com/cornerstonejs/cornerstoneWebImageLoader/issues/13
Coverage decreased (-0.07%) to 5.263% when pulling ff48ce55193611d501fd22dcb19725b55804fd94 on flamy-dev:blobs into fd929932fe04231e42b7d3afd271d20832e22e09 on cornerstonejs:master.
Not sure how the coverage got decreased since we are just importing the whole module for giving an illusion of coverage(I think)?
Also, can we have a release after this is merged @chafey(mentioning for notification since no new commit in last 6 months and you are mentioned as package author) ?
In the meanwhile if anyone wishes to use this I've published it to github package - https://github.com/flamy-dev/cornerstoneWebImageLoader/packages/297934
This change would be extremely useful. Thanks @meetmangukiya @coveralls It's quite obvious that this PR can't affect your tests.
What do expect me to do in order to help with merging this one?
@Inzeppelin don't think this is going to be merged, better fork