cornerstoneWADOImageLoader icon indicating copy to clipboard operation
cornerstoneWADOImageLoader copied to clipboard

feat: added voiLUTFunction

Open Ouwen opened this issue 1 year ago • 4 comments

This is to support voiLUTFunction in https://github.com/cornerstonejs/cornerstone3D-beta/pull/224

Ouwen avatar Sep 22 '22 19:09 Ouwen

Deploy Preview for cornerstone-wado-image-loader ready!

Name Link
Latest commit ac0d1647b426181a19fdbd00911f5ee5d8eb7bcc
Latest deploy log https://app.netlify.com/sites/cornerstone-wado-image-loader/deploys/6379acfbc4d31000092e07ca
Deploy Preview https://deploy-preview-476--cornerstone-wado-image-loader.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 22 '22 19:09 netlify[bot]

@sedghi

Ouwen avatar Sep 22 '22 19:09 Ouwen

This looks good but the build is failing and doesn't seem like it is your PR

4:12:22 PM: Installing NPM modules using NPM version 8.15.0
4:12:22 PM: npm WARN config tmp This setting is no longer used.  npm stores temporary files in a special
4:12:22 PM: npm WARN config location in the cache, and they are managed by
4:12:22 PM: npm WARN config     [`cacache`](http://npm.im/cacache).
4:12:22 PM: npm WARN config tmp This setting is no longer used.  npm stores temporary files in a special
4:12:22 PM: npm WARN config location in the cache, and they are managed by
4:12:22 PM: npm WARN config     [`cacache`](http://npm.im/cacache).
4:12:24 PM: npm ERR! code ERESOLVE
4:12:24 PM: npm ERR! ERESOLVE could not resolve
4:12:24 PM: npm ERR!
4:12:24 PM: npm ERR! While resolving: [email protected]
4:12:24 PM: npm ERR! Found: [email protected]
4:12:24 PM: npm ERR! node_modules/webpack
4:12:24 PM: npm ERR!   dev webpack@"^5.51.2" from the root project
4:12:24 PM: npm ERR!   peer webpack@">=2" from [email protected]
4:12:24 PM: npm ERR!   node_modules/babel-loader
4:12:24 PM: npm ERR!     dev babel-loader@"^8.2.2" from the root project
4:12:24 PM: npm ERR!   11 more (clean-webpack-plugin, copy-webpack-plugin, ...)
4:12:24 PM: npm ERR!
4:12:24 PM: npm ERR! Could not resolve dependency:
4:12:24 PM: npm ERR! peer webpack@"^2.0.0 || ^3.0.0 || ^4.0.0" from [email protected]
4:12:24 PM: npm ERR! node_modules/istanbul-instrumenter-loader
4:12:24 PM: npm ERR!   dev istanbul-instrumenter-loader@"^3.0.1" from the root project
4:12:24 PM: npm ERR!
4:12:24 PM: npm ERR! Conflicting peer dependency: [email protected]
4:12:24 PM: npm ERR! node_modules/webpack
4:12:24 PM: npm ERR!   peer webpack@"^2.0.0 || ^3.0.0 || ^4.0.0" from [email protected]
4:12:24 PM: npm ERR!   node_modules/istanbul-instrumenter-loader
4:12:24 PM: npm ERR!     dev istanbul-instrumenter-loader@"^3.0.1" from the root project
4:12:24 PM: npm ERR!
4:12:24 PM: npm ERR! Fix the upstream dependency conflict, or retry
4:12:24 PM: npm ERR! this command with --force, or --legacy-peer-deps
4:12:24 PM: npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
4:12:24 PM: npm ERR!
4:12:24 PM: npm ERR! See /opt/buildhome/.npm/eresolve-report.txt for a full report.
4:12:24 PM: npm ERR! A complete log of this run can be found in:
4:12:24 PM: npm ERR!     /opt/buildhome/.npm/_logs/2022-09-23T20_12_22_803Z-debug-0.log
4:12:24 PM: Error during NPM install
4:12:24 PM: Build was terminated: Build script returned non-zero exit co

sedghi avatar Sep 23 '22 20:09 sedghi

I had this issue as well and needed to yarn install instead of npm install

Ouwen avatar Sep 23 '22 20:09 Ouwen

:tada: This PR is included in version 4.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ohif-bot avatar Dec 01 '22 02:12 ohif-bot