cornerstoneWADOImageLoader icon indicating copy to clipboard operation
cornerstoneWADOImageLoader copied to clipboard

Wait until beforeSend header is returned before sending xhr request

Open erasromani opened this issue 1 year ago • 3 comments

In some cases, beforeSend method passes is asynchronous or returns a promise. For example, when the xhr request requires addition of an access token in the header and the retreival of the access token is done asynchronously, the beforeSend methos is therefore asynchronous. In this case, the current implementation does not wait for the header to be returned before sending the xhr request.

erasromani avatar Aug 04 '22 08:08 erasromani

Deploy Preview for cornerstone-wado-image-loader failed.

Name Link
Latest commit 5f8cb2c010ad927b85fb4616e0be88c7660bb5f5
Latest deploy log https://app.netlify.com/sites/cornerstone-wado-image-loader/deploys/62eb80c7772c030008b1654d

netlify[bot] avatar Aug 04 '22 08:08 netlify[bot]

with the code of your PR commit, the beforeSend is still sync

timtong1982 avatar Sep 20 '22 21:09 timtong1982

@wayfarer3130 Can you please look at this?

sedghi avatar Dec 01 '22 02:12 sedghi