cornerstonejs
Implements cancelFn to cancel pending XHR requests
The behaviour can be seen in the /examples/wadors/index.html and /examples/wadouri/index.html. It will probably requires simulating a slow network.
What I did creating the cancelFn in xhrRequests.js and carry it all the way back to loadImage.js
Looks pretty good to me, I just don't understand where the multipart decoding changes came from. Could you figure out why the editor is changing all the whitespace though? I don't see why Travis is failing either..
The code changes seem fine. It's a breaking change for anyone depending on dataSetCacheManager.load but I guess that isn't too many people. Seems fine for me. Thanks @diego0020!
Sorry, I have been away from medical imaging for a while. Does anyone want to take a shot at solving the conflicts?
@diego0020, thanks for the update! @fpt-mnes-phongtt6, @amrita-syn, @hungnm2904 my time is limited to complete this. If someone can resolve conflicts, this should be good to merge (you may need to create a new PR with current changes). Minimizing unnecessary changes, tests, etc. make it easier for me to merge as I have a higher degree of confidence the change:
- Accomplishes what it intends to do
- Does not have unwanted side effects