cornerstoneTools icon indicating copy to clipboard operation
cornerstoneTools copied to clipboard

Added support for controlling the segmentation fill opacity(alpha) for each segment in each series

Open Trenser-SandeepNayathil opened this issue 3 years ago • 1 comments

Added support for controlling the segmentation fill opacity(alpha) for each segment in each series. Added a new example of rendering with Fill Alpha per Label map for each series and unit test updates

  • Please check if the PR fulfills these requirements
  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This is a minor feature update in segmentation configuration.

  • What is the current behavior? (You can also link to an open issue here) Currently we can control the opacity of active and inactive label maps. So all inactive label maps segment will have only a single opacity.

  • What is the new behavior (if this is a feature change)? This is a minor feature update in segmentation configuration which allows to control all label maps(active or inactive) segment opacity independently from outside.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No, this PR will not introduce a breaking change, if not used the newly added configuration property, then existing work as previous.

  • Other information: Added new example to showcase the usage of the new added fill alpha configuration inside netlify-example\brush\index1.html Segment

Trenser-SandeepNayathil avatar Mar 07 '21 15:03 Trenser-SandeepNayathil

Codecov Report

Merging #1362 (cd99fa3) into master (f8a9110) will increase coverage by 0.69%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
+ Coverage   18.93%   19.63%   +0.69%     
==========================================
  Files         286      286              
  Lines        8676     8700      +24     
  Branches     1486     1488       +2     
==========================================
+ Hits         1643     1708      +65     
+ Misses       5820     5791      -29     
+ Partials     1213     1201      -12     
Impacted Files Coverage Δ
...modules/segmentationModule/defaultConfiguration.js 100.00% <ø> (ø)
...eventListeners/onImageRenderedBrushEventHandler.js 91.48% <100.00%> (+87.14%) :arrow_up:
src/stateManagement/imageIdSpecificStateManager.js 65.71% <0.00%> (+20.00%) :arrow_up:
src/stateManagement/toolState.js 38.70% <0.00%> (+38.70%) :arrow_up:
src/util/uuidv4.js 100.00% <0.00%> (+100.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8a9110...cd99fa3. Read the comment docs.

codecov[bot] avatar Mar 07 '21 15:03 codecov[bot]