cornerstoneTools
cornerstoneTools copied to clipboard
Pr/show suv maxmin rect ellip roi tool
- Please check if the PR fulfills these requirements
- [ ] The commit message follows our guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
-
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Shows max and min for rectangle and elliptical roi tools. Max and Min values are passed to calculateSuv when meanStdDevSuv is created.
-
What is the current behavior? (You can also link to an open issue here) Max and min SUV are not shown nor stored within meanStdDevSuv.
-
What is the new behavior (if this is a feature change)? Max and min SUV are now stored and shown for rectangle and elliptical roi tools.
-
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No changes should be required by users.
-
Other information:
Codecov Report
Merging #1349 (fc50c14) into master (8a261a2) will decrease coverage by
0.04%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
- Coverage 18.93% 18.89% -0.05%
==========================================
Files 286 286
Lines 8675 8694 +19
Branches 1486 1488 +2
==========================================
Hits 1643 1643
- Misses 5819 5836 +17
- Partials 1213 1215 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/tools/annotation/EllipticalRoiTool.js | 25.20% <0.00%> (-2.24%) |
:arrow_down: |
src/tools/annotation/RectangleRoiTool.js | 36.02% <0.00%> (-2.56%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8a261a2...fc50c14. Read the comment docs.
@dxlin Hi! Have you had any success with the changes in this PR? Looks like a very important addition!