cornerstoneTools icon indicating copy to clipboard operation
cornerstoneTools copied to clipboard

fix: bump version of cornerstone-math to v0.1.19

Open ladeirarodolfo opened this issue 4 years ago • 2 comments

  • Please check if the PR fulfills these requirements
  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Update cornerstone math to v 0.1.19

  • What is the current behavior? (You can also link to an open issue here) There are some unusual bugs when using crosshairs. They are caused by a math calculation on cMath.

  • What is the new behavior (if this is a feature change)? CMath to calculate intersections between lines are improved, some not displaying properly crosshairs might be fixed

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No

  • Other information:

ladeirarodolfo avatar Oct 05 '20 18:10 ladeirarodolfo

Codecov Report

Merging #1319 (c966198) into master (95c3b7c) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1319   +/-   ##
=======================================
  Coverage   20.16%   20.16%           
=======================================
  Files         287      287           
  Lines       10102    10102           
  Branches     2060     2060           
=======================================
  Hits         2037     2037           
  Misses       6852     6852           
  Partials     1213     1213           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95c3b7c...c966198. Read the comment docs.

codecov[bot] avatar Oct 05 '20 18:10 codecov[bot]

Maybe hold off on merging this until this followup PR on cornerstone-math has been merged. https://github.com/cornerstonejs/cornerstoneMath/pull/33 <- resolves an issue which stops ReferenceLines tool from rendering.

mikehazell avatar Nov 15 '20 23:11 mikehazell