cornerstoneMath icon indicating copy to clipboard operation
cornerstoneMath copied to clipboard

Published 20 hours ago • verified publisher icon cornerstonejs

rewrite with typescript

Open bingliang-zh opened this issue 5 years ago • 5 comments

  • add tsconfig.json (with strict on)

  • convert all js files to ts

  • remove applyMatrix3 from Vector3

  • BUILD SETTINGS are not set up currectly for now

bingliang-zh avatar Aug 08 '19 08:08 bingliang-zh

Coverage Status

Coverage increased (+9.7%) to 48.839% when pulling f3564e7f16e5bfd7e5a15eefc6a590baecaebea0 on bingliang-zh:rewrite-in-typescript into c89342021539339cfb9e0a908e0453216b8e460f on cornerstonejs:master.

coveralls avatar Aug 14 '19 06:08 coveralls

I think the remaining 8 issues checked by codeclimate are not so urgent to be fixed. Go on finishing other parts.

bingliang-zh avatar Aug 14 '19 13:08 bingliang-zh

There are some dependencies issues need Node 10. Would be nice to see travis-ci's node version being updated. All npm scripts are checked.

bingliang-zh avatar Aug 15 '19 03:08 bingliang-zh

I need some feedback.

bingliang-zh avatar Sep 30 '19 03:09 bingliang-zh

Travis CI failed due to this, how can I upgrade that?

error @typescript-eslint/[email protected]: The engine "node" is incompatible with this module. Expected version "^8.10.0 || ^10.13.0 || >=11.10.1". Got "9.11.2"

bingliang-zh avatar Oct 11 '19 12:10 bingliang-zh