cornerstone3D icon indicating copy to clipboard operation
cornerstone3D copied to clipboard

[Bug] One remaining circular dependency

Open salimkanoun opened this issue 1 year ago • 1 comments

Describe the Bug

Reported it for records, will look at it asap

Export "default" of module ".yarn/cache/@cornerstonejs-core-npm-1.30.1-f0f5e594e2-c5f862d85f.zip/node_modules/@cornerstonejs/core/dist/esm/cache/classes/ImageVolume.js" was reexported through module ".yarn/cache/@cornerstonejs-core-npm-1.30.1-f0f5e594e2-c5f862d85f.zip/node_modules/@cornerstonejs/core/dist/esm/cache/index.js" while both modules are dependencies of each other and will end up in different chunks by current Rollup settings. This scenario is not well supported at the moment as it will produce a circular dependency between chunks and will likely lead to broken execution order.

Steps to Reproduce

While building a project incuding cornerstone with vite / rollup

The current behavior

cicular dep alert

The expected behavior

should not have circular deps

OS

Linux

Node version

20

Browser

Chrome

salimkanoun avatar Nov 20 '23 09:11 salimkanoun