cornerstone3D icon indicating copy to clipboard operation
cornerstone3D copied to clipboard

feat: cache now stores image and volume based on URI internally

Open sedghi opened this issue 3 years ago • 1 comments

Previously cache would store images and volumes internally with keys of imageId and volumeId. The image/volumeId has the loader scheme which is totally unnecessary since the whole purpose of cache is to be able to retrieve the image/volume pixelData for an image that is already cached, no matter what loader was used to retrieved it

This PR changes the internal wiring of cache to work with URI.

In future, it might makes sense to change the surface API to also work with imagerURI, but for now, the API surface has not changed

sedghi avatar Sep 09 '22 22:09 sedghi

Deploy Preview for cornerstone-3d-docs failed.

Name Link
Latest commit a658d08624f700d40cd205b3dfb2ea3dff2d8db5
Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/631bc294cddb94000c1b2f06

netlify[bot] avatar Sep 09 '22 22:09 netlify[bot]

Can this solve memory exceeded issue? This is frequently coming when we do MPR even on series with less images (300-400) on a PC with 16GB RAM. Once below message comes then all other open browser tabs (also in other application) show same message.

image3

iconsys avatar Dec 07 '22 10:12 iconsys

@iconsys No it doesn't have anything to do with memory. What OS you are using? Can you record screen? or share anonimized data?

sedghi avatar Dec 07 '22 13:12 sedghi

@iconsys - take a look at PR: https://github.com/OHIF/Viewers/pull/3068 That resolves multiple issues with memory, in particular it prevent a reload of volume data for the previous study if you look at a new study. If you are seeing the issue on first load, however, then it won't fix things, but it does make the client quite a bit more stable.

wayfarer3130 avatar Dec 07 '22 20:12 wayfarer3130