cornerstone3D icon indicating copy to clipboard operation
cornerstone3D copied to clipboard

fix: Annotations showing up on incorrect images

Open plt-joey opened this issue 1 year ago • 1 comments

Context

Fixes issue described here: https://github.com/cornerstonejs/cornerstone3D/issues/1455

Changes & Results

Modified the image URI check in the isReferenceViewable function in StackViewport from an endsWith match to an exact match. This stops annotations on images with IDs like dicom:126 (which is the format used by the wadoURI filemanager) from displaying on the images dicom:26 and dicom:6 as well.

Testing

The repro provided in the linked issue demonstrates the bug, replacing the UMD build of @cornerstonejs/core with one containing this change will fix the bug.

Checklist

PR

  • [x] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.

Code

  • [x] My code has been well-documented (function documentation, inline comments, etc.)

  • [x] I have run the yarn build:update-api to update the API documentation, and have committed the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)

Public Documentation Updates

  • [x] The documentation page has been updated as necessary for any public API additions or removals.

Tested Environment

  • [x] "OS: Windows 11"
  • [x] "Node version: 18.12.1"
  • [x] "Browser: Chrome 128.0.6613.120"

plt-joey avatar Sep 10 '24 14:09 plt-joey

Deploy Preview for cornerstone-3d-docs ready!

Name Link
Latest commit b1c78caa01f220cc470d21c103ac578173f3d6b6
Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/672299a401b7680008b34133
Deploy Preview https://deploy-preview-1460--cornerstone-3d-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 10 '24 14:09 netlify[bot]

@sedghi Is there anything I need to do to fix this pipeline and get this merged in? This bug is blocking us.

plt-joey avatar Nov 05 '24 14:11 plt-joey

oh sorry

sedghi avatar Nov 05 '24 14:11 sedghi