cornerstone3D icon indicating copy to clipboard operation
cornerstone3D copied to clipboard

Build error with WebPack 5

Open Celian-abd opened this issue 3 years ago • 3 comments

Hi there,

we just wanted to warn that Cornerstone3D has a build issue with Webpack 5 due to the detect-gpu library

The issue is raised here : https://github.com/pmndrs/detect-gpu/issues/89

For those working with react 18 with create-react-app will have this issue.

I put this here because once detect-gpu will be fixed it will need to upgrade cornerstone 3d dependencies

Salim & Celian

Celian-abd avatar Jun 10 '22 09:06 Celian-abd

We are facing this issue and we're unable to build a internal prod version due to this issue.
Do you have any workaround in the meantime?

On our side we gonna fork detect-gpu library and try to remove terser webpack plugin which seems to fix this issue as mentioned in https://github.com/pmndrs/detect-gpu/issues/89#issuecomment-1165234884 and we'll let you know

eric-taix avatar Jul 06 '22 09:07 eric-taix

Hello,

We found and submitted a fix, available here.

I hope it can be merged soon!

gabriellebaudy avatar Jul 07 '22 15:07 gabriellebaudy

Is your problem resolved now? @Celian-abd

sedghi avatar Jul 29 '22 18:07 sedghi