cornerstone3D icon indicating copy to clipboard operation
cornerstone3D copied to clipboard

feat(ROIThresholdsTools): Made the Rectangle and Circle ROIStartEndThresholds works on other planes

Open Celian-abd opened this issue 1 year ago • 1 comments

Context

Updated version of the Rectangle/Circle ROIStartEndThreshold tools so they can work on other then acquisition plane.

Changes & Results

  • Update calculateCachedStats for other plane

Testing

yarn run example RectangleROIStartEndThreshold or on CircleROIStartEndThreshold

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments, etc.)

  • [] I have run the yarn build:update-api to update the API documentation, and have committed the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Celian-abd avatar Feb 28 '24 12:02 Celian-abd

Deploy Preview for cornerstone-3d-docs ready!

Name Link
Latest commit ba773d7dff66f2d518da43052639409436e6de36
Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6675d4b109a64f0008f1ba03
Deploy Preview https://deploy-preview-1128--cornerstone-3d-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 28 '24 12:02 netlify[bot]

@sedghi We've made some changes to the way we were doing the 3D ROI. Now there is no more sliceIndex but we are using instead the world coordinates of where the annotation is drawn and we compare it to the focalpoint of the camera.

Also we added the calculation of the basic stats with all the points contained in the 3D roi and the posibility to show the textbost like we have the for the other tools.

Celian-abd avatar Apr 05 '24 13:04 Celian-abd

@sedghi I think you might have tested an older version.

Here is what I have : https://streamable.com/yx1qd4

Celian-abd avatar May 27 '24 10:05 Celian-abd

I haven't forgotten about this. We are just shipping a 3.8.1 for OHIF, and for that, I don't want to include this PR since we are upgrading cs3d versions. After that is merged (pretty soon), I'll come back to this.

sedghi avatar Jun 05 '24 17:06 sedghi

Hi @sedghi, is there a chance you could review this PR ? We enhanced it, i think it is ready for review

salimkanoun avatar Jun 14 '24 08:06 salimkanoun

Yes, we released version 3.8.1, so I will review this issue. Apologies for the delay.

sedghi avatar Jun 15 '24 01:06 sedghi

@sedghi thank you ! Next week we will make you a PR to update the command that set the start / stop slice in ohif as now the z limits are set by position and not to the viewport slice index

salimkanoun avatar Jun 21 '24 19:06 salimkanoun

(PR in ohif not cornerstone)

salimkanoun avatar Jun 21 '24 19:06 salimkanoun