cornerstone3D
cornerstone3D copied to clipboard
feat(ROIThresholdsTools): Made the Rectangle and Circle ROIStartEndThresholds works on other planes
Context
Updated version of the Rectangle/Circle ROIStartEndThreshold tools so they can work on other then acquisition plane.
Changes & Results
- Update calculateCachedStats for other plane
Testing
yarn run example RectangleROIStartEndThreshold or on CircleROIStartEndThreshold
Checklist
PR
- [] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.
Code
-
[] My code has been well-documented (function documentation, inline comments, etc.)
-
[] I have run the
yarn build:update-apito update the API documentation, and have committed the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
- [] The documentation page has been updated as necessary for any public API additions or removals.
Tested Environment
- [] "OS:
- [] "Node version:
- [] "Browser:
Deploy Preview for cornerstone-3d-docs ready!
| Name | Link |
|---|---|
| Latest commit | ba773d7dff66f2d518da43052639409436e6de36 |
| Latest deploy log | https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6675d4b109a64f0008f1ba03 |
| Deploy Preview | https://deploy-preview-1128--cornerstone-3d-docs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@sedghi We've made some changes to the way we were doing the 3D ROI. Now there is no more sliceIndex but we are using instead the world coordinates of where the annotation is drawn and we compare it to the focalpoint of the camera.
Also we added the calculation of the basic stats with all the points contained in the 3D roi and the posibility to show the textbost like we have the for the other tools.
@sedghi I think you might have tested an older version.
Here is what I have : https://streamable.com/yx1qd4
I haven't forgotten about this. We are just shipping a 3.8.1 for OHIF, and for that, I don't want to include this PR since we are upgrading cs3d versions. After that is merged (pretty soon), I'll come back to this.
Hi @sedghi, is there a chance you could review this PR ? We enhanced it, i think it is ready for review
Yes, we released version 3.8.1, so I will review this issue. Apologies for the delay.
@sedghi thank you ! Next week we will make you a PR to update the command that set the start / stop slice in ohif as now the z limits are set by position and not to the viewport slice index
(PR in ohif not cornerstone)