datuner icon indicating copy to clipboard operation
datuner copied to clipboard

Change assertions to error message prompts if the assertions are meant to be visible to the users

Open gl387 opened this issue 8 years ago • 2 comments

gl387 avatar Aug 08 '17 14:08 gl387

I will deal with it tomorrow. So for the assertions only used for debug, should we just delete them? Is there any way to leave these assertions for debug version with some compilation pragma?

On Tue, Aug 8, 2017 at 10:40 PM, Gai Liu [email protected] wrote:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cornell-zhang/datuner/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AEqZ1VmpS74qLIHWRX2iCPuiKbX2R-WOks5sWHNZgaJpZM4Ow1PF .

ChangXuSunny avatar Aug 08 '17 15:08 ChangXuSunny

This is low priority for now. We will need to come up with a systematic way for error prompts. We should keep the assertions. But note that assertions are only useful for tool developers, and they are not intended for the users.

zhangzhiru avatar Aug 08 '17 15:08 zhangzhiru