Cornelius Weig

Results 44 comments of Cornelius Weig

Yes, the `--depth` is an optimization and not important any time soon. But only fetching `master` would already be useful. That way we avoid that people pull useless references from...

Can you please run with `-v=5` option and show the log output? Also, please bear in mind that admin privileges are required to install plugins on Windows due to the...

A major consideration for me is that many users only run `krew` very occasionally. Those users will not benefit from a one-time warning, because it is easily forgotten. Thus, we'd...

Well another idea is to make this fully manual like `echo my-index >> $HOME/.krew/trust`. This should be easy enough to do for sysadmins and we don't make an API contract....

> wait for someone to complain and then pick a direction from there 😆 Yes, I fully agree! @chriskim06 what's your take on this?

/lifecycle frozen Let's come back to this when multi-index work is done.

IIRC, we decided to show the warning on updates, because plugin updates do not get vetted at all and could ship entirely different software. How about showing the warning just...

Are you saying that this is not good enough? > How about showing the warning just a single time instead for every updated plugin? Would that be good enough?

So you suggest to simply ignore that we are using different patterns?

Go 1.14 has improved support for deferred cleanup routines in tests. This should also be handled, either here or elsewhere