react-native-video-player icon indicating copy to clipboard operation
react-native-video-player copied to clipboard

Add fullscreen button in Android

Open isAlmogK opened this issue 7 years ago • 11 comments

The full-screen option is not showing on Andriod not sure why. I'm using the lastest version

"react-native-video": "^2.0.0",
"react-native-video-controls": "^1.3.0",
"react-native-video-player": "^0.8.2", 

Here is my code

<VideoPlayer
   endWithThumbnail
   thumbnail={{uri: selectedPhoto.url.thumbnail}}
   video={{uri: selectedPhoto.url.compressedFile}}
   disableFullscreen={false}
/>

isAlmogK avatar Sep 19 '17 01:09 isAlmogK

Fullscreen isn't fully implemented in Android yet, you can check out this pull request https://github.com/cornedor/react-native-video-player/pull/38. The readme has some instructions on how to set it up.

cornedor avatar Sep 19 '17 19:09 cornedor

@cornedor any reason the PR was not merged?

isAlmogK avatar Sep 21 '17 23:09 isAlmogK

If I do you have to manually copy the native code from a folder in node_modules. If you do not do that you get an error. I still have to put some time into getting this to work with react-native link

cornedor avatar Sep 22 '17 08:09 cornedor

@cornedor yea that would be great if it can work with jus react native link

isAlmogK avatar Sep 25 '17 05:09 isAlmogK

Still full-screen option is not showing on Andriod

bisht2ankit avatar Dec 02 '17 13:12 bisht2ankit

Still full-screen option is not showing on Andriod

NitishAgrawal avatar Jun 06 '18 07:06 NitishAgrawal

Is there any update on this ? :(

meliodev avatar Aug 04 '20 00:08 meliodev

There is no solution worthy of being published yet. Feel free to look into it! Sadly, this feature requires consistent Java and Android knowledge.

TheDanielMoli avatar Aug 04 '20 08:08 TheDanielMoli

I have a fork of the repository to add the fullscreen button on Android. If you add the native module in Android for the video player in your app, it will show the fullscreen button and work: https://github.com/aschambers/react-native-video-player Of course this requires some knowledge of Android and Java though.

aschambers avatar Nov 13 '20 04:11 aschambers

i have same problem after doing all the things mentioned for android full screen

sinafbd avatar Nov 19 '20 20:11 sinafbd

Some update here?

ttibau avatar Oct 25 '21 01:10 ttibau