Dark mode: can't read non-focused buffer name

[chinwobble]

Great colour scheme!

I just have a minor issue. On windows + GVIM I have two buffers open:

Below the active buffer, I can read the name of the other buffer.

Here are my settings:

let g:github_colors_soft = 1
let g:airline_theme='github'
colorscheme github
set background=dark

[chinwobble]

I think the issue is here:

if s:is_dark
  " base0 is now darkest
  let s:colors.base0        = s:lib.darktext[0]
  let s:colors.base1        = s:lib.darktext[1]
  let s:colors.base2        = s:lib.darktext[2]
  let s:colors.base3        = s:lib.darktext[3]
  let s:colors.base4        = s:lib.numDarkest
else
  let s:colors.base0          = s:lib.base0
  let s:colors.base1          = s:lib.base1
  let s:colors.base2          = s:lib.base2
  let s:colors.base3          = s:lib.base3
endif

When you use dark theme, it is set to darkest tone. However it should be the lightest tone.

https://github.com/cormacrelf/vim-colors-github/blob/bf5ba2ed899687c28370995787b8de3abe5a8153/colors/github.vim#L201

[cormacrelf]

I don't use airline anymore and I may have forgotten to update it. If anyone wants to fix the airline colours that'd be cool. But it will be in the airline theme not the main colour list. See the recent changes to the lightline theme for some idea of what should change.