Cormac Relf
Cormac Relf
Ok, this is better. ### Before (non-prelude cell) ```starlark # all four calls relate to the build file cell and will all agree. STATIC_CONFIG = read_config(...) STATIC_CELL = native.get_cell_name() def...
I got it to evaluate build files as build files, etc. and uhh this is amazing
Ok, this was quite a lot of stuff. But it works great. There are a few things that I think will get annoying, but the feature is useful enough that...
Reminder for me to check if print() in evaluated starlark code messes up the LSP stdio. I turned off printing in starlark_bin when LSP is evaluating but didn't check this...
Ok, I was wondering why this didn't work on the prelude and as usual it's because the prelude is bundled so the eval part just evaluates the bundled sources, which...
You are welcome!
Bit of an update, I've been using this and improving types (see all the other PRs). Turns out running the actual typechecker is more useful than actually evaluating if you...
I'm going to split this into a few more PRs: - the buck2_error parts of this one, which fixes the parse errors not getting spans, and preps for cross-file errors...
Usually in this situation I would just submit a PR to the crate in question that makes the build script easier to adapt. In this case by not writing an...
Now see https://github.com/facebook/buck2/issues/918, fixing that will help here