Cormac Relf

Results 323 comments of Cormac Relf

The TODOs around symlinking are related to https://github.com/facebook/buck2/issues/222

> However, once we are going through that path, maybe we should just delete `upload_blob` entirely and reuse `upload`? That already takes a `InlinedBlobWithDigest` so then we could have fewer...

Hi @benbrittain, I haven't had any time to work on this recently. I've given you push access to my fork cormacrelf/buck2, so you can keep working on the rbe-writes branch.

You can also just create an empty file at `mode/mac` as a workaround, if you have `fbcode = root` in your .buckconfig's repository aliases. See also https://github.com/facebook/buck2/issues/402 for the other...

This is where local materialize deps + output dir creation + execution happens, if anyone wants to give it a crack. A reasonable first step would be to define a...

There is a `rules_nixpkgs` for Bazel. They don't seem to be using the NIX_ environment variables to do linking, at all: rather, they construct symlinks into /nix/store and pass those...

@ndmitchell The genrule approach can't work with system_rust_toolchain as-is, because it doesn't allow configuring `RustToolchainInfo.compiler`. If it *did* allow that, the genrule would look SOMETHING like this, but even this...

Buck uses its own environment variables for protoc and protoc include. They are called BUCK2_BUILD_PROTOC and BUCK2_BUILD_PROTOC_INCLUDE. You may have to override those instead.

`toolchain_alias` is not in prelude. I think it should be. I've needed it too. Currently there's only an example in https://github.com/facebook/buck2/blob/main/examples/bootstrap/toolchains/toolchain.bzl