Cormac Relf

Here's a run with GK_LOCK_DEBUG=1, v2.4.0 https://travis-ci.org/cormacrelf/angular-skyhook/jobs/405467762 Didn't produce a commit. I verified the branch myself, it should have.

You were right not to accept that code, well done @SuperSandro2000, good instinct. I got distracted by this and decided to do a review, firstly of the PKCE implementation and...

Also I haven't read the rest of the codebase enough to know for sure, but this PR doesn't make it obvious that the PKCE code_verifier is actually stored anywhere. Sure...

Nope, no hang. Just prints out this (with commas instead of these pretty newlines): ``` /Users/cormac/.rbenv/versions/1.9.3-p0/lib/ruby/site_ruby/1.9.1 /Users/cormac/.rbenv/versions/1.9.3-p0/lib/ruby/site_ruby/1.9.1/x86_64-darwin11.2.0 /Users/cormac/.rbenv/versions/1.9.3-p0/lib/ruby/site_ruby /Users/cormac/.rbenv/versions/1.9.3-p0/lib/ruby/vendor_ruby/1.9.1 /Users/cormac/.rbenv/versions/1.9.3-p0/lib/ruby/vendor_ruby/1.9.1/x86_64-darwin11.2.0 /Users/cormac/.rbenv/versions/1.9.3-p0/lib/ruby/vendor_ruby /Users/cormac/.rbenv/versions/1.9.3-p0/lib/ruby/1.9.1 /Users/cormac/.rbenv/versions/1.9.3-p0/lib/ruby/1.9.1/x86_64-darwin11.2.0 ```

Some notes: 1. I have fuzz tested this for an hour on the default settings. There was an initial hit due to some stuff that's no longer an issue because...

I'm adding this, string parser done already

Actually lol, starting to think I didn't need the string parser for the wire format... :duck:

I'm having a look at this in the hope that we can inject a markdown parser in doc comments. This is obviously a great start, but from what I can...

The combined injections trick works. Thanks for the tip @archseer! Will PR separately, based on this PR (to handle the more-than-three-/ case, which Erlang doesn't have to worry about). The...

See #128 which merges successive doc comments, which it seems would be a precondition to adding rust embeds for fenced code blocks in documentation.