Corey Lewis

Results 34 comments of Corey Lewis

I missed some changes required in crefine, all of the tests should pass now. I am a bit concerned that I am missing something with https://github.com/seL4/l4v/pull/526/commits/da1a7e8dc7b26f28983bef27d77a8c3cf4c94793, but it solves my...

> @michaelmcinerney it might make sense to do a test merge with MCS for this one to see if it leads to massive conflicts or not. Unless the perl/sed path...

It took a bit longer than I hoped, but I now have a branch with an updated MCS. Is there anything blocking this PR being merged? The gitlint test is...

> Good to bring them in sync again. A lot of these look like wrong indentation got fixed on the MCS side. No problem reverting this here, but we should...

> I made a fork of your branch with my suggestions, see [here](https://github.com/seL4/seL4/compare/master...Indanz:seL4:corlewis/set-handler-params). > > While working on that I think I found a corner case that is currently not...

> > While working on that I think I found a corner case that is currently not handled correctly: If a badged cap is passed, and another badge value is...

> I implemented your suggestion to check for null cap and force pushed to my branch. Sorry, what I was thinking is a bit more complicated, since a null cap...

> Yes, but changing the badge on a null-cap doesn't make any sense, so this distinction seems pointless. With my version you would get an error if you tried that,...

> > What I've been trying to handle is the case where deriveCap can return a null cap if for whatever reason certain non-endpoint caps are passed in. > >...

I've pushed my first attempt at this [here](https://github.com/corlewis/seL4/commit/2455b4d9235ab2707bdd513a5b9abd8cc2bb173b). I haven't properly tested all of the cases yet, but I think it should handle everything that we have mentioned so far,...