Peter Goodspeed-Niklaus

Results 78 comments of Peter Goodspeed-Niklaus

Looks plausible! Once you have the tests going, I'd be interested to see the PR; feel free to tag me onto that when it's ready. I think globs are a...

@kfcampbell any progress to report? My team would also appreciate a fix for this.

Refactoring the code is fine, to an extent. This is very much a style thing, and I don't want to pre-approve anything that I'll regret later on. That said, I...

Sounds good. With regard to benches, I'd recommend `criterion` instead of nightly benches. I want to expose the entire surface of the library, including benchmarking, to end-users without requiring a...

Feel free to make a PR. This feature is not important enough to me personally that I am likely to get to it in finite time, but I'm always happy...

An interesting proposal! My first reaction is positive, though I haven't yet devoted any real thought to whether this would cause any problems. Please go ahead and write an implementation...

It would be very useful if the documentation at each of these options stated clearly that the option was only valid within `--encrypt`. It's one thing to see that these...

Huh, interesting! In that case, the forward version of the problem ("given the number of attendees, find the number of print jobs") is more interesting than the reverse version of...

I [added a test case](https://github.com/exercism/rust/pull/1225) in the Rust track to address a [related issue](https://github.com/exercism/rust/issues/1221). Didn't attempt to generalize that test case into this repo because it depends on a Rust-specific...

>> `UnknownWord` error > > Perhaps that's worth a test also? Probably. On the one hand, specifying the behavior more thoroughly is always a good idea. On the other hand,...