Corey McKrill
Corey McKrill
I don't see any problem with just having the one Pull Quote style and the one Quote style. And in that regard, I don't think we'd want to rename the...
Looks like a classic thumbnail cropping-to-the-center issue. We might be able to get a better thumbnail for Devin's in particular. The tricky part with adding just their name as an...
@beafialho thoughts on this?
Found the issue for the Sharing block: https://github.com/Automattic/jetpack/issues/19694
The usages in 7241d17 are necessary to override some `!important` rules that are generated and output by Gutenberg (or maybe Core?) based on the `contentSize` and `wideSize` values set in...
> I'm not sure that Filters an object before it is inserted via the REST API is quite accurate. At this point, the refund was potentially already persisted in the...
> Also the get_wcpay_card_info method in the new PaymentInfo class and [ReceiptRenderingEngine::get_woo_pay_data](https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/src/Internal/ReceiptRendering/ReceiptRenderingEngine.php#L420C19-L420C35) are very similar, maybe we could merge them? Yep, I definitely think we should. I was hoping to...
Ok, I consolidated the card payment info methods in d7142b53f6. I think I should probably add another unit test for Tap-To-Pay, but I don't have an example payload to work...
@albarin good catch! @Konamiman do you think the way I merged the two methods is sufficient? Any other thoughts about the modifications to the receipt engine before we merge?
Hey @sol-loup, thanks for the PR. Can you explain more about the use case here?