nvm-windows icon indicating copy to clipboard operation
nvm-windows copied to clipboard

altered runElevated to accept command and args fixing the elevation bug

Open craig-et opened this issue 2 years ago • 2 comments

Current runElevated seems to have issues elevating from non-admin terminal. This change should resolve the elevation issue and return the nicer usage, mirroring the interface for exec.Command.

This change currently does not soft escalate if command run fails in a non elevated state first, can be added if requested.

NB: I recognise that there are a couple PR's attempting to resolve this issue already pending, they seem to have gone stale, I had tried their impl's but they did not appear to work for me during testing

feel free to reject this PR if you take one of the other in its stead

craig-et avatar Jul 04 '22 00:07 craig-et

This PR is stale because it has been open 45 days with no activity.

github-actions[bot] avatar Aug 03 '22 02:08 github-actions[bot]

This PR is stale because it has been open 45 days with no activity.

github-actions[bot] avatar Sep 03 '22 02:09 github-actions[bot]

Thank you for this. I ended up using it, but I had to add it manually due to several other changes that moved code around. I added a mention/thank you in the release notes.

coreybutler avatar Nov 01 '22 00:11 coreybutler