nvm-windows
nvm-windows copied to clipboard
coreybutler
Fix npm install
There seems to have been a hiccup when refactoring the temp dir for NPM. See how the tempDir variable was modified -- the line to unzip then proceeds to unzip from the wrong location. This should solve https://github.com/coreybutler/nvm-windows/issues/1209 -- untested. Need to make sure that the rest of the flow works...
Can confirm this fixes the issue of npm not being downloaded because it doesn't recognize the temporary folder. Built the source myself with this code to confirm. Thank you kiwkwag.
Just ran into this bug and it killed my vibe for nearly a whole day. Thanks for submitting the patch!
Hey @BinToss, thanks for the review. Can you please instruct me how to proceed to get this merged?
Hey @BinToss, thanks for the review. Can you please instruct me how to proceed to get this merged?
Now we wait for a maintainer to approve a review. Third parties can submit reviews, but cannot submit Approval reviews.
This PR won't be used because the fix is more involved than a one-liner. I've already completed the work, but the release is held up by the arm64 build. GitHub recently added support for this in GitHub Actions, but I've exceeded the maximum GitHub Actions minutes with other projects over the last two months. I anticipate getting this build process complete this month, but my primary focus has been on Author/Runtime (the successor to this project).
Please remember, I am the only person doing any reviews/support on this. My time is finite and my primary focus is on what's next (because I'm as tired of the slow update cycles as everyone else is). I appreciate everyone's understanding.
This PR is stale because it has been open 45 days with no activity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Curious with this being such a breaking issue and a small change why is this not merged and new version of nvm published?
@DawtCom see https://github.com/coreybutler/nvm-windows/issues/1240#issuecomment-2899153179
This PR is stale because it has been open 45 days with no activity.
A fixed release is available here along with updated readme and build configs (was this vibe-coded?)
A fixed release is available here along with updated readme and build configs (was this vibe-coded?)
This worked, but I had to add the elevate.cmd and elevate.vbs files manually. Also it still uses the Local\Temp path instead of Local so I had to move the downloaded node version to the correct directory as well.
This PR is stale because it has been open 45 days with no activity.
@coreybutler I understand your time is finite, can you please consider delegating review approval with write access into someone with more bandwidth?
You said you would do it in a month in May, and it's understandable you haven't had time but maybe this is why delegating into someone that would have write access could be interesting for the community your app built.
Thanks.
