nvm-windows Show terminal warning only when user did not enter arguments.

Show terminal warning only when user did not enter arguments.

Open johnrom opened this issue 1 year ago • 6 comments

closes #1068

(doesn't fix the underlying terminal check, but limits the issue to users who didn't enter any nvm command)

Only check terminal when there are no arguments, because it's possible the user clicked the .exe. If there are arguments, assume the user knows what they're doing. Add some launch tasks in .vscode to demonstrate the difference. The warning now indicates that if you are in an unsupported terminal, to try running nvm help instead.

Feel free to remove .vscode/launch.json if you do not use VS Code. I used it to create an example of:

Launching nvm without commands in debug console -- opens warning indicating nvm can only be run in a terminal
Launching nvm in external console (like command prompt) -- prints normal help message in terminal
Launching nvm version in debug console -- works normally