nvm-windows icon indicating copy to clipboard operation
nvm-windows copied to clipboard

Arm64

Open wsobolewski opened this issue 1 year ago • 6 comments

Support windows-arm64.

wsobolewski avatar Dec 04 '23 09:12 wsobolewski

This PR is stale because it has been open 45 days with no activity.

github-actions[bot] avatar Jan 04 '24 01:01 github-actions[bot]

This PR is stale because it has been open 45 days with no activity.

github-actions[bot] avatar Feb 04 '24 01:02 github-actions[bot]

I built/tested this version, there's an error in the version check logic preventing the install of the latest ARM64 (22.5.1) version:

As currently written, for the latest version (22.5.1), it passes the main version check, but then fails the minor version check since the value of minor is 5 which is lower than 9.

func IsNodeArm64bitAvailable(v string) bool {
	if v == "latest" {
		return true
	}

	// Anything below version 8 doesn't have a 64 bit version
	vers := strings.Fields(strings.Replace(v, ".", " ", -1))
	main, _ := strconv.ParseInt(vers[0], 0, 0)
	minor, _ := strconv.ParseInt(vers[1], 0, 0)
	fmt.Println("main "+ strconv.FormatInt(main,10) + " minor "+strconv.FormatInt(minor,10))
	if main < 19 {
		return false
	}
	if minor < 9{
		return false
	}
	
	// TODO: fixme. Assume a 64 bit version exists
	return true
}

talynone avatar Jul 28 '24 14:07 talynone