node-windows icon indicating copy to clipboard operation
node-windows copied to clipboard

Feature/allow command arguments

Open julianhille opened this issue 6 years ago • 4 comments

Add possibility to add arguments to the script to be called

julianhille avatar Jul 09 '19 11:07 julianhille

Thanks for the PR,

I believe the intention is to keep the api calls identical across the three OS packages though. Any additional configuration or specific functionality should be left to to the developer to add via a wrapper or some other means.

jdziat avatar Jul 09 '19 11:07 jdziat

That is why I added a pr to add arguments for all the three packages.

julianhille avatar Jul 10 '19 11:07 julianhille

My apologies should of checked the PRs on those. So we need consensus across all three repos.

Also can you provide use cases where a flags property would benefit over the methods I purposed. The only one I can think of is modifying the service outside of these packages. However it is very early for me so I may not be thinking clearly.

jdziat avatar Jul 10 '19 11:07 jdziat

I've got a single app compiled / packaged which needs some command line args to start as a service.

julianhille avatar Jul 10 '19 21:07 julianhille